From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] versionsort: support reorder prerelease suffixes
Date: Mon, 9 Mar 2015 08:01:21 +0700 [thread overview]
Message-ID: <CACsJy8Bpta0rw1rjN8ROcUykPK508bvH_bvAJzLQQa6L6OmH7w@mail.gmail.com> (raw)
In-Reply-To: <xmqqmw3s5j1y.fsf@gitster.dls.corp.google.com>
On Thu, Mar 5, 2015 at 8:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> +versionsort.prereleaseSuffix::
>>> + When version sort is used in linkgit:git-tag[1], prerelease
>>> + tags (e.g. "1.0-rc1") may appear after the main release
>>> + "1.0". By specifying the suffix "-rc" in this variable,
>>> + "1.0-rc1" will appear before "1.0". One variable assignment
>>> + per suffix.
>>
>> I think the last half-sentence want to mean that
>>
>> [versionsort]
>> prereleaseSuffix = -pre
>> prereleaseSuffix = -rc
>>
>> is the supported way to write, and not
>>
>> [versionsort]
>> prereleaseSuffix = -pre -rc
>>
>> but it probably is unclear unless the reader already knows what it
>> is trying to say. The reader also needs to learn somewhere how the
>> order of the entries affects the result.
>
> This is already in 'next', so could you fix that half-sentence in
> the documentation via an incremental update?
How about..
".. "1.0-rc1" will appear before "1.0". This key can be specified
multiple times, one for each suffix. The order of suffixes in the
config file determines the sorting order (e.g. if "-pre" appears
before "-rc" in the config file then 1.0-preXX is sorted before
1.0-rcXX). The sorting order between different suffixes is undefined
if they are in multiple config files"
--
Duy
next prev parent reply other threads:[~2015-03-09 1:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 19:14 [RFH] GSoC 2015 application Jeff King
2015-02-18 19:32 ` Jeff King
2015-02-24 12:01 ` Johannes Schindelin
2015-02-24 12:06 ` [msysGit] " Jeff King
2015-02-24 12:25 ` Johannes Schindelin
2015-02-24 12:28 ` [msysGit] " Jeff King
2015-02-25 9:25 ` Johannes Schindelin
2015-02-25 9:39 ` Matthieu Moy
2015-02-25 10:25 ` Matthieu Moy
2015-02-25 12:15 ` Johannes Schindelin
2015-02-24 17:32 ` Matthieu Moy
2015-02-24 18:25 ` Junio C Hamano
2015-02-24 20:33 ` Johannes Schindelin
2015-02-24 21:02 ` Junio C Hamano
2015-02-24 23:56 ` Matthieu Moy
2015-02-25 0:34 ` [msysGit] " Stefan Beller
2015-02-25 9:25 ` Michael J Gruber
2015-02-25 8:44 ` Johannes Schindelin
2015-02-25 10:04 ` [msysGit] " Christian Couder
2015-02-25 10:02 ` Duy Nguyen
2015-02-25 12:10 ` Johannes Schindelin
2015-02-18 21:54 ` Junio C Hamano
2015-02-19 5:49 ` Junio C Hamano
2015-02-19 10:32 ` Matthieu Moy
2015-02-20 2:00 ` Jeff King
2015-02-20 10:06 ` Matthieu Moy
2015-02-20 10:22 ` Dennis Kaarsemaker
2015-02-20 10:34 ` Matthieu Moy
2015-02-20 23:06 ` Eric Sunshine
2015-02-20 10:31 ` [PATCH 1/3] microprojects: tweaks after discussion with Peff Matthieu Moy
2015-02-20 10:31 ` [PATCH 2/3] GSoC ideas: git bisect fixed/unfixed Matthieu Moy
2015-02-20 10:31 ` [PATCH 3/3] idea: Be nicer to the user on tracked/untracked merge conflicts Matthieu Moy
2015-02-20 3:26 ` [RFH] GSoC 2015 application Duy Nguyen
2015-02-20 7:13 ` Jeff King
2015-02-20 8:26 ` Junio C Hamano
2015-02-21 3:02 ` Support customized reordering in version sort Duy Nguyen
2015-02-21 3:25 ` Junio C Hamano
2015-02-21 3:33 ` Duy Nguyen
2015-02-21 5:12 ` Junio C Hamano
2015-02-21 5:37 ` Junio C Hamano
2015-02-26 10:44 ` [PATCH] versionsort: support reorder prerelease suffixes Nguyễn Thái Ngọc Duy
2015-02-27 21:37 ` Junio C Hamano
2015-03-05 1:28 ` Junio C Hamano
2015-03-09 1:01 ` Duy Nguyen [this message]
2015-03-10 7:52 ` Junio C Hamano
2015-03-10 8:03 ` Eric Sunshine
2015-03-10 10:16 ` [PATCH] config.txt: update versioncmp.prereleaseSuffix Nguyễn Thái Ngọc Duy
2015-02-20 5:35 ` [RFH] GSoC 2015 application Michael Haggerty
2015-02-20 7:29 ` Jeff King
2015-02-20 8:06 ` Junio C Hamano
2015-02-20 9:39 ` Matthieu Moy
2015-02-20 9:48 ` Jeff King
2015-02-20 11:35 ` Jeff King
2015-02-23 8:02 ` Matthieu Moy
2015-02-23 15:36 ` Jeff King
2015-03-04 22:05 ` Philip Oakley
2015-03-04 23:55 ` Stefan Beller
2015-03-05 0:17 ` Philip Oakley
2015-03-05 0:22 ` Junio C Hamano
2015-03-05 0:32 ` Stefan Beller
2015-03-05 1:17 ` Junio C Hamano
2015-03-05 6:19 ` Junio C Hamano
2015-03-06 11:24 ` Duy Nguyen
2015-03-05 0:26 ` Duy Nguyen
2015-03-05 10:28 ` Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 1/6] upload-pack: move shallow deepen code out of receive_needs() Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 2/6] upload-pack: move "shallow" sending code out of deepen() Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 3/6] upload-pack: remove unused variable "backup" Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 4/6] upload-pack: move "unshallow" sending code out of deepen() Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 5/6] shallow.c: implement a generic shallow boundary finder based on rev-list Nguyễn Thái Ngọc Duy
2015-03-05 10:28 ` [PATCH 6/6] upload-pack: example code to use get_shallow_commits_by_rev_list Nguyễn Thái Ngọc Duy
2015-02-26 13:10 ` [RFH] GSoC 2015 application Duy Nguyen
2015-03-04 10:31 ` Jeff King
2015-03-04 11:21 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Bpta0rw1rjN8ROcUykPK508bvH_bvAJzLQQa6L6OmH7w@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).