From: Duy Nguyen <pclouds@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Ben Peart <Ben.Peart@microsoft.com>,
Jonathan Tan <jonathantanmy@google.com>,
Mike Hommey <mh@glandium.org>,
Lars Schneider <larsxschneider@gmail.com>,
Eric Wong <e@80x24.org>,
Christian Couder <chriscool@tuxfamily.org>,
Jeff Hostetler <jeffhost@microsoft.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb()
Date: Sun, 22 Jul 2018 11:05:01 +0200 [thread overview]
Message-ID: <CACsJy8B+NBgKFZbrN2etgkecv6yH4NGWogVqzK0K=01MSO2naQ@mail.gmail.com> (raw)
In-Reply-To: <20180713174959.16748-7-chriscool@tuxfamily.org>
On Fri, Jul 13, 2018 at 7:50 PM Christian Couder
<christian.couder@gmail.com> wrote:
> @@ -477,8 +478,8 @@ static int batch_objects(struct batch_options *opt)
>
> for_each_loose_object(batch_loose_object, &sa, 0);
> for_each_packed_object(batch_packed_object, &sa, 0);
> - if (repository_format_partial_clone)
> - warning("This repository has extensions.partialClone set. Some objects may not be loaded.");
> + if (has_remote_odb())
> + warning("This repository uses an odb. Some objects may not be loaded.");
I can see the string is not marked for translation before, but since
you're updating it, please consider _() if needed. Maybe also say
"remote object database" instead of odb
--
Duy
next prev parent reply other threads:[~2018-07-22 9:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 17:49 [PATCH v3 0/9] Introducing remote ODBs Christian Couder
2018-07-13 17:49 ` [PATCH v3 1/9] fetch-object: make functions return an error code Christian Couder
2018-07-13 17:49 ` [PATCH v3 2/9] Add initial remote odb support Christian Couder
2018-07-13 17:49 ` [PATCH v3 3/9] remote-odb: implement remote_odb_get_direct() Christian Couder
2018-07-13 17:49 ` [PATCH v3 4/9] remote-odb: implement remote_odb_get_many_direct() Christian Couder
2018-07-13 17:49 ` [PATCH v3 5/9] remote-odb: add remote_odb_reinit() Christian Couder
2018-07-13 17:49 ` [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb() Christian Couder
2018-07-22 9:05 ` Duy Nguyen [this message]
2018-07-13 17:49 ` [PATCH v3 7/9] Use odb.origin.partialclonefilter instead of core.partialclonefilter Christian Couder
2018-07-13 17:49 ` [PATCH v3 8/9] t0410: test fetching from many promisor remotes Christian Couder
2018-07-13 17:49 ` [PATCH v3 9/9] Documentation/config: add odb.<name>.promisorRemote Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8B+NBgKFZbrN2etgkecv6yH4NGWogVqzK0K=01MSO2naQ@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Ben.Peart@microsoft.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=larsxschneider@gmail.com \
--cc=mh@glandium.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).