list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <>
Cc: Junio C Hamano <>, Jeff King <>,
	Ben Peart <>,
	Jonathan Tan <>,
	Nguyen Thai Ngoc Duy <>,
	Mike Hommey <>,
	Lars Schneider <>,
	Eric Wong <>,
	Christian Couder <>,
	Jeff Hostetler <>,
	Eric Sunshine <>
Subject: [PATCH v3 0/9] Introducing remote ODBs
Date: Fri, 13 Jul 2018 19:49:50 +0200	[thread overview]
Message-ID: <> (raw)

This path series is a follow up from the patch series called "odb
remote" that I sent earlier this year, which was itself a follow up
from previous series. See the links section for more information.

As with the previous "odb remote" series, this series is only about
integrating with the promisor/narrow clone work and showing that it
makes it possible to use more than one promisor remote. Everything
that is not necessary for that integration has been removed for now
(though you can still find it in one of my branches on GitHub if you

There is one test in patch 8/9 that shows that more than one promisor
remote can now be used, but I still feel that it could be interesting
to add other such tests, so I am open to ideas in this area.

Changes compared to V2 of this patch series

  - fix unused variable in patch 2/9: the "SQUASH???" patch that Junio
    had created (thanks!) has been squashed

High level overview of this patch series

All the patches except 2/9 are unchanged compared to V2.

  - Patch 1/9:

This makes functions in fetch-object.c return an error code, which is
necessary to later tell that they failed and try another remote odb
when there is more than one. This could also just be seen as a fix to
these functions.

  - Patch 2/9:

This introduces the minimum infrastructure for remote odbs.

  - Patches 3/9 and 4/9:

These patches implement remote_odb_get_direct() and
remote_odb_get_many_direct() using the functions from fetch-object.c.
These new functions will be used in following patches to replace the
functions from fetch-object.c.

  - Patch 5/9:

This implement remote_odb_reinit() which will be needed to reparse the
remote odb configuration.

  - Patches 6/9 and 7/9:

These patches integrate the remote odb mechanism into the
promisor/narrow clone code. The "extensions.partialClone" config
option is replaced by "odb.<name>.promisorRemote" and
"core.partialCloneFilter" is replaced by

  - Patch 8/9:

This adds a test case that shows that now more than one promisor
remote can be used.

  - Patch 9/9:

This starts documenting the remote odb mechanism.


I am not sure that it is ok to completely replace the
"extensions.partialclone" config option. Even if it is fully replaced,
no "extensions.remoteodb" is implemented in these patches, as maybe
the "extensions.partialclone" name could be kept even if the
underlying mechanism is the remote odb mechanism.

Anyway I think that the remote odb mechanism is much more extensible,
so I think using "extensions.partialclone" to specify a promisor
remote should be at least deprecated.


This patch series on GitHub:


Discussions related to previous versions:


Previous "odb remote" series:

Version 1 and 2 of the "Promisor remotes and external ODB support" series:

Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub:

Christian Couder (9):
  fetch-object: make functions return an error code
  Add initial remote odb support
  remote-odb: implement remote_odb_get_direct()
  remote-odb: implement remote_odb_get_many_direct()
  remote-odb: add remote_odb_reinit()
  Use remote_odb_get_direct() and has_remote_odb()
  Use odb.origin.partialclonefilter instead of core.partialclonefilter
  t0410: test fetching from many promisor remotes
  Documentation/config: add odb.<name>.promisorRemote

 Documentation/config.txt      |   5 ++
 Makefile                      |   2 +
 builtin/cat-file.c            |   5 +-
 builtin/fetch.c               |  13 ++--
 builtin/gc.c                  |   3 +-
 builtin/repack.c              |   3 +-
 cache.h                       |   2 -
 connected.c                   |   3 +-
 environment.c                 |   1 -
 fetch-object.c                |  15 ++--
 fetch-object.h                |   6 +-
 list-objects-filter-options.c |  51 +++++++------
 list-objects-filter-options.h |   3 +-
 odb-helper.c                  |  45 +++++++++++
 odb-helper.h                  |  24 ++++++
 packfile.c                    |   3 +-
 remote-odb.c                  | 137 ++++++++++++++++++++++++++++++++++
 remote-odb.h                  |  10 +++
 setup.c                       |   7 +-
 sha1-file.c                   |  14 ++--
 t/      |  58 +++++++++-----
 t/         |   4 +-
 t/              |   2 +-
 t/      |   4 +-
 t/        |   2 +-
 unpack-trees.c                |   6 +-
 26 files changed, 342 insertions(+), 86 deletions(-)
 create mode 100644 odb-helper.c
 create mode 100644 odb-helper.h
 create mode 100644 remote-odb.c
 create mode 100644 remote-odb.h


             reply	other threads:[~2018-07-13 17:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 17:49 Christian Couder [this message]
2018-07-13 17:49 ` [PATCH v3 1/9] fetch-object: make functions return an error code Christian Couder
2018-07-13 17:49 ` [PATCH v3 2/9] Add initial remote odb support Christian Couder
2018-07-13 17:49 ` [PATCH v3 3/9] remote-odb: implement remote_odb_get_direct() Christian Couder
2018-07-13 17:49 ` [PATCH v3 4/9] remote-odb: implement remote_odb_get_many_direct() Christian Couder
2018-07-13 17:49 ` [PATCH v3 5/9] remote-odb: add remote_odb_reinit() Christian Couder
2018-07-13 17:49 ` [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb() Christian Couder
2018-07-22  9:05   ` Duy Nguyen
2018-07-13 17:49 ` [PATCH v3 7/9] Use odb.origin.partialclonefilter instead of core.partialclonefilter Christian Couder
2018-07-13 17:49 ` [PATCH v3 8/9] t0410: test fetching from many promisor remotes Christian Couder
2018-07-13 17:49 ` [PATCH v3 9/9] Documentation/config: add odb.<name>.promisorRemote Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v3 0/9] Introducing remote ODBs' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone