From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Denton Liu" <liu.denton@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Anmol Mago" <anmolmago@gmail.com>,
briankyho@gmail.com, david.lu97@outlook.com,
shirui.wang@hotmail.com
Subject: Re: [PATCH v2] completion: use builtin completion for format-patch
Date: Thu, 1 Nov 2018 16:40:54 +0100 [thread overview]
Message-ID: <CACsJy8AowaAW91wGMYbC8aTOB1NoqQN-5NGx=qUCHp0i6zQRDA@mail.gmail.com> (raw)
In-Reply-To: <xmqqk1lxvaj6.fsf@gitster-ct.c.googlers.com>
On Thu, Nov 1, 2018 at 2:42 AM Junio C Hamano <gitster@pobox.com> wrote:
> >> @@ -2080,16 +2071,19 @@ _git_send_email ()
> >> return
> >> ;;
> >> --*)
> >> - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
> >> - --compose --confirm= --dry-run --envelope-sender
> >> - --from --identity
> >> - --in-reply-to --no-chain-reply-to --no-signed-off-by-cc
> >> - --no-suppress-from --no-thread --quiet --reply-to
> >> - --signed-off-by-cc --smtp-pass --smtp-server
> >> - --smtp-server-port --smtp-encryption= --smtp-user
> >> - --subject --suppress-cc= --suppress-from --thread --to
> >> - --validate --no-validate
> >> - $__git_format_patch_options"
> >> + __gitcomp "--all --annotate --attach --bcc --binary --cc --cc= --cc-cmd
> >> + --chain-reply-to --compose --confirm= --cover-letter --dry-run
> >> + --dst-prefix= --envelope-sender --from --full-index --identity
> >> + --ignore-if-in-upstream --inline --in-reply-to --in-reply-to=
> >> + --keep-subject --no-attach --no-chain-reply-to --no-prefix
> >> + --no-signature --no-signed-off-by-cc --no-suppress-from --not --notes
> >> + --no-thread --no-validate --numbered --numbered-files
> >> + --output-directory --quiet --reply-to --reroll-count --signature
> >> + --signed-off-by-cc --signoff --smtp-encryption= --smtp-pass
> >> + --smtp-server --smtp-server-port --smtp-user --src-prefix=
> >> + --start-number --stdout --subject --subject-prefix= --suffix=
> >> + --suppress-cc= --suppress-from --thread --thread= --to --to=
> >> + --validate"
> >
> > I have no comment about this. In an ideal world, sendemail.perl could
> > be taught to support --git-completion-helper but I don't think my
> > little remaining Perl knowledge (or time) is enough to do it. Perhaps
> > this will do. I don't know.
>
> So "all", "attach", etc. are added to this list while these similar
> options are lost from the other variable? Is this a good trade-off?
Not sure if I understand you correctly, but it looks to me that the
options in git-send-email.perl are well organized, so we could add
--git-completon-helper in that script to print all send-email specific
options, then call "git format-patch --git-completion-helper" to add a
bunch more. The options that are handled by setup_revisions() will
have to be maintained manually here like $__git_format_patch_options
and added on top in both _git_send_email () and _git_format_patch ().
So, nothing option is lost and by the time setup_revisions() supports
-git-completion-helper, we can get rid of the manual shell variable
too. The downside is, lots of work, probably.
--
Duy
next prev parent reply other threads:[~2018-11-01 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:57 [PATCH] completion: use builtin completion for format-patch Denton Liu
2018-10-30 2:20 ` Junio C Hamano
2018-10-30 3:50 ` Denton Liu
2018-10-30 6:38 ` [PATCH v2] " Denton Liu
2018-10-30 7:33 ` Junio C Hamano
2018-10-30 15:29 ` Duy Nguyen
2018-11-01 1:42 ` Junio C Hamano
2018-11-01 15:40 ` Duy Nguyen [this message]
2018-11-01 23:52 ` Junio C Hamano
2018-11-03 6:03 ` Duy Nguyen
2018-11-03 7:59 ` Denton Liu
2018-11-03 8:29 ` Duy Nguyen
2018-11-03 10:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8AowaAW91wGMYbC8aTOB1NoqQN-5NGx=qUCHp0i6zQRDA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=anmolmago@gmail.com \
--cc=briankyho@gmail.com \
--cc=david.lu97@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=shirui.wang@hotmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).