From: Duy Nguyen <pclouds@gmail.com>
To: liu.denton@gmail.com, "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
anmolmago@gmail.com, briankyho@gmail.com, david.lu97@outlook.com,
shirui.wang@hotmail.com
Subject: Re: [PATCH v2] completion: use builtin completion for format-patch
Date: Tue, 30 Oct 2018 16:29:07 +0100 [thread overview]
Message-ID: <CACsJy8Ajc0qWw3RLak1PRPXvQzMHjaFuWJ6BPkhiVg=7fQvCnA@mail.gmail.com> (raw)
In-Reply-To: <72331ce9275ce995009fe8dd3d586bb9d71f2cbf.1540881141.git.liu.denton@gmail.com>
On Tue, Oct 30, 2018 at 7:39 AM Denton Liu <liu.denton@gmail.com> wrote:
>
> This patch offloads completion functionality for format-patch to
> __gitcomp_builtin. In addition to this, send-email was borrowing some
> completion options from format-patch so those options are moved into
> send-email's completions.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>
> I ran t9902-completion.sh on this patch and it seems to pass. Thus, this
> should address the concerns about losing some completion options in
> send-email.
>
> ---
> contrib/completion/git-completion.bash | 34 +++++++++++---------------
> 1 file changed, 14 insertions(+), 20 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d63d2dffd..cb4ef6723 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1531,15 +1531,6 @@ _git_fetch ()
> __git_complete_remote_or_refspec
> }
>
> -__git_format_patch_options="
> - --stdout --attach --no-attach --thread --thread= --no-thread
> - --numbered --start-number --numbered-files --keep-subject --signoff
> - --signature --no-signature --in-reply-to= --cc= --full-index --binary
> - --not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=
> - --inline --suffix= --ignore-if-in-upstream --subject-prefix=
> - --output-directory --reroll-count --to= --quiet --notes
> -"
> -
> _git_format_patch ()
> {
> case "$cur" in
> @@ -1550,7 +1541,7 @@ _git_format_patch ()
> return
> ;;
> --*)
> - __gitcomp "$__git_format_patch_options"
> + __gitcomp_builtin format-patch
We do want to keep some extra options back because __gitcomp_builtin
cannot show all supported options of format-patch. The reason is a
subset of options is handled by setup_revisions() which does not have
--git-completion-helper support.
> @@ -2080,16 +2071,19 @@ _git_send_email ()
> return
> ;;
> --*)
> - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
> - --compose --confirm= --dry-run --envelope-sender
> - --from --identity
> - --in-reply-to --no-chain-reply-to --no-signed-off-by-cc
> - --no-suppress-from --no-thread --quiet --reply-to
> - --signed-off-by-cc --smtp-pass --smtp-server
> - --smtp-server-port --smtp-encryption= --smtp-user
> - --subject --suppress-cc= --suppress-from --thread --to
> - --validate --no-validate
> - $__git_format_patch_options"
> + __gitcomp "--all --annotate --attach --bcc --binary --cc --cc= --cc-cmd
> + --chain-reply-to --compose --confirm= --cover-letter --dry-run
> + --dst-prefix= --envelope-sender --from --full-index --identity
> + --ignore-if-in-upstream --inline --in-reply-to --in-reply-to=
> + --keep-subject --no-attach --no-chain-reply-to --no-prefix
> + --no-signature --no-signed-off-by-cc --no-suppress-from --not --notes
> + --no-thread --no-validate --numbered --numbered-files
> + --output-directory --quiet --reply-to --reroll-count --signature
> + --signed-off-by-cc --signoff --smtp-encryption= --smtp-pass
> + --smtp-server --smtp-server-port --smtp-user --src-prefix=
> + --start-number --stdout --subject --subject-prefix= --suffix=
> + --suppress-cc= --suppress-from --thread --thread= --to --to=
> + --validate"
I have no comment about this. In an ideal world, sendemail.perl could
be taught to support --git-completion-helper but I don't think my
little remaining Perl knowledge (or time) is enough to do it. Perhaps
this will do. I don't know.
--
Duy
next prev parent reply other threads:[~2018-10-30 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:57 [PATCH] completion: use builtin completion for format-patch Denton Liu
2018-10-30 2:20 ` Junio C Hamano
2018-10-30 3:50 ` Denton Liu
2018-10-30 6:38 ` [PATCH v2] " Denton Liu
2018-10-30 7:33 ` Junio C Hamano
2018-10-30 15:29 ` Duy Nguyen [this message]
2018-11-01 1:42 ` Junio C Hamano
2018-11-01 15:40 ` Duy Nguyen
2018-11-01 23:52 ` Junio C Hamano
2018-11-03 6:03 ` Duy Nguyen
2018-11-03 7:59 ` Denton Liu
2018-11-03 8:29 ` Duy Nguyen
2018-11-03 10:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8Ajc0qWw3RLak1PRPXvQzMHjaFuWJ6BPkhiVg=7fQvCnA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=anmolmago@gmail.com \
--cc=briankyho@gmail.com \
--cc=david.lu97@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=shirui.wang@hotmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).