From: Duy Nguyen <pclouds@gmail.com>
To: Fredrik Gustafsson <iveqy@iveqy.com>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Rewriting git-repack.sh in C
Date: Sat, 3 Aug 2013 17:03:52 +0700 [thread overview]
Message-ID: <CACsJy8A-xo97MC-vBmqCrvvSDMWKd_MxnRrTBSeSqcQ1HifzJA@mail.gmail.com> (raw)
In-Reply-To: <20130803063325.GJ19369@paksenarrion.iveqy.com>
On Sat, Aug 3, 2013 at 1:33 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:
> On Fri, Aug 02, 2013 at 09:10:59PM +0700, Duy Nguyen wrote:
>> > So my question is, how you'd generally approach rewriting a
>> > shell script in C.
>>
>> Start a new process via start_command/run_command interface. It's
>> safer to retain the process boundary at this stage. You can try to
>> integrate further later.
>
> Is it really the right approach to just replace sh with C? IMHO forking
> and wait for the result should not be done if it can be avoided. It just
> adds overhead.
Agreed. As I said in another post, I misread this as rewriting
git-rebase.sh, which is a lot more complicated.
> Of course you can argue that just replace sh with C is a good first step
> towards to actually do the command in "full C". Altough I'm afraid that
> that will get such low priority that it won't be done.
One of the reasons I started porting git-repack.sh since 2011 and
never finished it.
--
Duy
next prev parent reply other threads:[~2013-08-03 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 13:48 Rewriting git-repack.sh in C Stefan Beller
2013-08-02 14:10 ` Duy Nguyen
2013-08-02 16:36 ` Duy Nguyen
2013-08-03 6:33 ` Fredrik Gustafsson
2013-08-03 10:03 ` Duy Nguyen [this message]
2013-08-07 14:00 ` [PATCH 0/4] " Stefan Beller
2013-08-07 14:00 ` [PATCH 1/4] Build in git-repack Stefan Beller
2013-08-07 14:28 ` Matthieu Moy
2013-08-07 15:48 ` Junio C Hamano
2013-08-07 16:45 ` Stefan Beller
2013-08-08 2:44 ` Duy Nguyen
2013-08-07 14:00 ` [PATCH 2/4] backup_file dummy function Stefan Beller
2013-08-08 2:45 ` Duy Nguyen
2013-08-07 14:00 ` [PATCH 3/4] pack-objects: do not print usage when repacking Stefan Beller
2013-08-08 6:40 ` Antoine Pelisse
2013-08-07 14:00 ` [PATCH 4/4] repack: add unpack-unreachable Stefan Beller
2013-08-05 10:34 ` Rewriting git-repack.sh in C Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8A-xo97MC-vBmqCrvvSDMWKd_MxnRrTBSeSqcQ1HifzJA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=iveqy@iveqy.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).