git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] wildmatch test: remove redundant duplicate test
@ 2017-05-26 20:56 Ævar Arnfjörð Bjarmason
  2017-05-29  0:54 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2017-05-26 20:56 UTC (permalink / raw)
  To: git
  Cc: Junio C Hamano, Nguyễn Thái Ngọc Duy,
	Ævar Arnfjörð Bjarmason

Remove a test line that's exactly the same as the preceding
line.

This was brought in in commit feabcc173b ("Integrate wildmatch to
git", 2012-10-15), these tests are originally copied from rsync.git,
but the duplicate line was never present there, so must have just
snuck in during integration with git by accident.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t3070-wildmatch.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index ef509df351..7ca69f4bed 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -135,7 +135,6 @@ match 1 x '5' '[[:xdigit:]]'
 match 1 x 'f' '[[:xdigit:]]'
 match 1 x 'D' '[[:xdigit:]]'
 match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
-match 1 x '_' '[[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:graph:][:lower:][:print:][:punct:][:space:][:upper:][:xdigit:]]'
 match 1 x '.' '[^[:alnum:][:alpha:][:blank:][:cntrl:][:digit:][:lower:][:space:][:upper:][:xdigit:]]'
 match 1 x '5' '[a-c[:digit:]x-z]'
 match 1 x 'b' '[a-c[:digit:]x-z]'
-- 
2.13.0.303.g4ebf302169


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wildmatch test: remove redundant duplicate test
  2017-05-26 20:56 [PATCH] wildmatch test: remove redundant duplicate test Ævar Arnfjörð Bjarmason
@ 2017-05-29  0:54 ` Junio C Hamano
  2017-05-29  7:22   ` Ævar Arnfjörð Bjarmason
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2017-05-29  0:54 UTC (permalink / raw)
  To: Ævar Arnfjörð Bjarmason
  Cc: git, Nguyễn Thái Ngọc Duy

Thanks.  Did you run "sort | uniq -c" on it or something ;-)?

Will apply.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] wildmatch test: remove redundant duplicate test
  2017-05-29  0:54 ` Junio C Hamano
@ 2017-05-29  7:22   ` Ævar Arnfjörð Bjarmason
  0 siblings, 0 replies; 3+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2017-05-29  7:22 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List, Nguyễn Thái Ngọc Duy

On Mon, May 29, 2017 at 2:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Thanks.  Did you run "sort | uniq -c" on it or something ;-)?

I've been writing a new backend for wildmatch(). Was wondering what
the difference in these two failing tests was, turns out there was
none.

> Will apply.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-29  7:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 20:56 [PATCH] wildmatch test: remove redundant duplicate test Ævar Arnfjörð Bjarmason
2017-05-29  0:54 ` Junio C Hamano
2017-05-29  7:22   ` Ævar Arnfjörð Bjarmason

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).