From: Brandon Casey <drafnel@gmail.com>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd
Date: Wed, 22 Apr 2020 12:05:57 -0700 [thread overview]
Message-ID: <CA+sFfMdudQ-cWbXajQ_92LZLOOOnTxmQmmsUo3dY1eKCL5-Y6Q@mail.gmail.com> (raw)
In-Reply-To: <452EC7D1-BE96-4172-8F70-3E7384C87280@jrtc27.com>
On Wed, Apr 22, 2020 at 11:50 AM Jessica Clarke <jrtc27@jrtc27.com> wrote:
>
> On 22 Apr 2020, at 19:48, Brandon Casey <drafnel@gmail.com> wrote:
> > introduced
> > this feature that would make fopen() fail when opening a directory for
> > use on the platforms where fread() of a directory did not fail,
> > instead of trying to wrap fread().
>
> Then the current autoconf test is wrong and likely causing confusion:
>
> > AC_RUN_IFELSE(
> > [AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
> > [[
> > FILE *f = fopen(".", "r");
> > return f != NULL;]])],
> > [ac_cv_fread_reads_directories=no],
> > [ac_cv_fread_reads_directories=yes])
> > ])
Yes, we should attempt to call fread() there. If either the fopen()
fails or the fread() fails, then that should mean that
FREAD_READS_DIRECTORIES is not necessary.
-Brandon
next prev parent reply other threads:[~2020-04-22 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:33 [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd Jessica Clarke
2020-04-22 16:41 ` Jonathan Nieder
2020-04-22 17:48 ` Junio C Hamano
2020-04-22 18:48 ` Brandon Casey
2020-04-22 18:50 ` Jessica Clarke
2020-04-22 19:05 ` Brandon Casey [this message]
2020-04-22 18:54 ` Brandon Casey
2020-04-22 19:13 ` Brandon Casey
2020-04-22 19:58 ` Jeff King
2020-04-22 21:18 ` Brandon Casey
2020-04-24 5:51 ` Jeff King
2020-04-22 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+sFfMdudQ-cWbXajQ_92LZLOOOnTxmQmmsUo3dY1eKCL5-Y6Q@mail.gmail.com \
--to=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=jrtc27@jrtc27.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).