From: Jonathan Nieder <jrnieder@gmail.com>
To: Jessica Clarke <jrtc27@jrtc27.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd
Date: Wed, 22 Apr 2020 09:41:50 -0700 [thread overview]
Message-ID: <20200422164150.GA140314@google.com> (raw)
In-Reply-To: <20200422153347.40018-1-jrtc27@jrtc27.com>
Jessica Clarke wrote:
> GNU/Hurd is another platform that behaves like this. Set it to
> UnfortunatelyYes so that config directory files are correctly processed.
> This fixes the corresponding 'proper error on directory "files"' test in
> t1308-config-set.sh.
>
> Thanks-to: Jeff King <peff@peff.net>
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
> ---
> config.mak.uname | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
> diff --git a/config.mak.uname b/config.mak.uname
> index 0ab8e00938..3e526f6b9f 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -308,6 +308,7 @@ ifeq ($(uname_S),GNU)
> NO_STRLCPY = YesPlease
> HAVE_PATHS_H = YesPlease
> LIBC_CONTAINS_LIBINTL = YesPlease
> + FREAD_READS_DIRECTORIES = UnfortunatelyYes
> endif
I wonder why we set up this knob this way. A lot of operating systems
support fopen(..., "r") of a directory --- wouldn't it make sense for
FREAD_READS_DIRECTORIES to be the default and for users on stricter
platforms to be able to set FREAD_DOES_NOT_READ_DIRECTORIES if they
want to speed Git up by taking advantage of their saner fread?
Thanks,
Jonathan
next prev parent reply other threads:[~2020-04-22 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:33 [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd Jessica Clarke
2020-04-22 16:41 ` Jonathan Nieder [this message]
2020-04-22 17:48 ` Junio C Hamano
2020-04-22 18:48 ` Brandon Casey
2020-04-22 18:50 ` Jessica Clarke
2020-04-22 19:05 ` Brandon Casey
2020-04-22 18:54 ` Brandon Casey
2020-04-22 19:13 ` Brandon Casey
2020-04-22 19:58 ` Jeff King
2020-04-22 21:18 ` Brandon Casey
2020-04-24 5:51 ` Jeff King
2020-04-22 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422164150.GA140314@google.com \
--to=jrnieder@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrtc27@jrtc27.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).