From: Jacob Keller <jacob.keller@gmail.com>
To: Git mailing list <git@vger.kernel.org>
Subject: git send-email Cc with cruft not working as expected
Date: Tue, 22 Aug 2017 16:15:54 -0700 [thread overview]
Message-ID: <CA+P7+xrtZYUjPcVMkA+x8B57w+LxjjU8YSKcE77DrWne7449rg@mail.gmail.com> (raw)
Hi,
I recently found an issue with git-send-email where it does not
properly remove the cruft of an email address when sending using a Cc:
line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
which is the standard way Linux upstream expects the stable Ccs to be,
and I saw several examples of this in the past.
However, this gets converted into a cc of
"stable@vger.kernel.org#4.10+" which isn't a valid address obviously.
This does work as expected if you remember to
Cc: <stable@vger.kernel.org> # 4.10+
I would have assumed that validate_address would kick in and let me
know that the address I'd given isn't valid, or something along those
lines.
I tried to come up with a test for this, but modifying t9001 seemed to
cause other failures and I couldn't detangle exactly how the tests fit
together.
Is this simply expected behavior and I need to remember to use <>
around the address?
Thanks,
Jake
next reply other threads:[~2017-08-22 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 23:15 Jacob Keller [this message]
2017-08-22 23:18 ` git send-email Cc with cruft not working as expected Stefan Beller
2017-08-22 23:30 ` Jacob Keller
2017-08-22 23:36 ` Stefan Beller
2017-08-23 10:02 ` Matthieu Moy
2017-08-23 10:21 ` [RFC PATCH 1/2] send-email: fix garbage removal after address Matthieu Moy
2017-08-23 10:21 ` [RFC PATCH 2/2] send-email: don't use Mail::Address, even if available Matthieu Moy
2017-08-23 21:59 ` [RFC PATCH 1/2] send-email: fix garbage removal after address Jacob Keller
2017-08-24 20:32 ` Junio C Hamano
2017-08-25 9:11 ` Matthieu Moy
2017-08-25 9:11 ` [PATCH v2 " Matthieu Moy
2017-08-25 9:12 ` [PATCH v2 2/2] send-email: don't use Mail::Address, even if available Matthieu Moy
2017-08-23 22:49 ` git send-email Cc with cruft not working as expected Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+P7+xrtZYUjPcVMkA+x8B57w+LxjjU8YSKcE77DrWne7449rg@mail.gmail.com \
--to=jacob.keller@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).