From: Jacob Keller <jacob.keller@gmail.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] send-email: fix garbage removal after address
Date: Wed, 23 Aug 2017 14:59:40 -0700 [thread overview]
Message-ID: <CA+P7+xrUgC9M9VeZTKL4K=ro23arrWHL+F5YUUTj_ZU8t24kkg@mail.gmail.com> (raw)
In-Reply-To: <20170823102102.20120-1-git@matthieu-moy.fr>
On Wed, Aug 23, 2017 at 3:21 AM, Matthieu Moy <git@matthieu-moy.fr> wrote:
> This is a followup over 9d33439 (send-email: only allow one address
> per body tag, 2017-02-20). The first iteration did allow writting
>
> Cc: <foo@example.com> # garbage
>
> but did so by matching the regex ([^>]*>?), i.e. stop after the first
> instance of '>'. However, it did not properly deal with
>
> Cc: foo@example.com # garbage
>
> Fix this using a new function strip_garbage_one_address, which does
> essentially what the old ([^>]*>?) was doing, but dealing with more
> corner-cases. Since we've allowed
>
> Cc: "Foo # Bar" <foobar@example.com>
>
> in previous versions, it makes sense to continue allowing it (but we
> still remove any garbage after it). OTOH, when an address is given
> without quoting, we just take the first word and ignore everything
> after.
>
> Signed-off-by: Matthieu Moy <git@matthieu-moy.fr>
> ---
I pulled this and tested it for my issue, and it fixes the problem for
me. I think the approach in the code was solid too, extracting out the
logic helps make the code more clear.
Thanks,
Jake
next prev parent reply other threads:[~2017-08-23 22:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 23:15 git send-email Cc with cruft not working as expected Jacob Keller
2017-08-22 23:18 ` Stefan Beller
2017-08-22 23:30 ` Jacob Keller
2017-08-22 23:36 ` Stefan Beller
2017-08-23 10:02 ` Matthieu Moy
2017-08-23 10:21 ` [RFC PATCH 1/2] send-email: fix garbage removal after address Matthieu Moy
2017-08-23 10:21 ` [RFC PATCH 2/2] send-email: don't use Mail::Address, even if available Matthieu Moy
2017-08-23 21:59 ` Jacob Keller [this message]
2017-08-24 20:32 ` [RFC PATCH 1/2] send-email: fix garbage removal after address Junio C Hamano
2017-08-25 9:11 ` Matthieu Moy
2017-08-25 9:11 ` [PATCH v2 " Matthieu Moy
2017-08-25 9:12 ` [PATCH v2 2/2] send-email: don't use Mail::Address, even if available Matthieu Moy
2017-08-23 22:49 ` git send-email Cc with cruft not working as expected Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+P7+xrUgC9M9VeZTKL4K=ro23arrWHL+F5YUUTj_ZU8t24kkg@mail.gmail.com' \
--to=jacob.keller@gmail.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).