From: Joel Holdsworth <jholdsworth@nvidia.com>
To: Luke Diamand <luke@diamand.org>
Cc: Git Users <git@vger.kernel.org>
Subject: RE: [PATCH 6/6] git-p4: Resolve RCS keywords in binary
Date: Fri, 10 Dec 2021 10:51:53 +0000 [thread overview]
Message-ID: <BN8PR12MB33611BD4A606919F343F0639C8719@BN8PR12MB3361.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAE5ih7_gvbOwvoO4deqDm_8Nk9XWzrdHGHEsgdiEb7+7YxtGwg@mail.gmail.com>
> This comment appears to have been stripped out, does that mean that we
> now *do* try to demangle keywords on utf16?
Good point. I guess the comment should stay.
Though really... I'm not sure what we should do with utf16 files. Currently the RCS keywords just won't be resolved, with no warning for the user! I guess we could resolve them, if we had a reliable way of detecting UTF-16?
next prev parent reply other threads:[~2021-12-10 10:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 20:10 [PATCH 0/6] Transition git-p4.py to support Python 3 only Joel Holdsworth
2021-12-09 20:10 ` [PATCH 1/6] git-p4: Always pass cmd arguments to subprocess as a python lists Joel Holdsworth
2021-12-09 22:42 ` Junio C Hamano
2021-12-09 20:10 ` [PATCH 2/6] git-p4: Don't print shell commands as " Joel Holdsworth
2021-12-09 20:10 ` [PATCH 3/6] git-p4: Removed support for Python 2 Joel Holdsworth
2021-12-09 22:44 ` Junio C Hamano
2021-12-09 23:07 ` rsbecker
2021-12-10 3:25 ` David Aguilar
2021-12-10 10:44 ` Joel Holdsworth
2021-12-09 20:10 ` [PATCH 4/6] git-p4: Decode byte strings before printing Joel Holdsworth
2021-12-09 22:47 ` Junio C Hamano
2021-12-10 8:40 ` Fabian Stelzer
2021-12-10 10:48 ` Joel Holdsworth
2021-12-10 10:41 ` Joel Holdsworth
2021-12-09 20:10 ` [PATCH 5/6] git-p4: Eliminate decode_stream and encode_stream Joel Holdsworth
2021-12-09 20:10 ` [PATCH 6/6] git-p4: Resolve RCS keywords in binary Joel Holdsworth
2021-12-10 7:57 ` Luke Diamand
2021-12-10 10:51 ` Joel Holdsworth [this message]
2021-12-10 0:48 ` [PATCH 0/6] Transition git-p4.py to support Python 3 only Ævar Arnfjörð Bjarmason
2021-12-10 10:37 ` Joel Holdsworth
2021-12-10 11:30 ` Ævar Arnfjörð Bjarmason
2021-12-10 21:34 ` Junio C Hamano
2021-12-10 21:53 ` rsbecker
2021-12-11 21:00 ` Elijah Newren
2021-12-12 8:55 ` Luke Diamand
2021-12-10 7:53 ` Luke Diamand
2021-12-10 10:54 ` Joel Holdsworth
2021-12-11 9:58 ` Luke Diamand
2021-12-13 13:47 ` Joel Holdsworth
2021-12-13 19:29 ` Junio C Hamano
2021-12-13 19:58 ` Joel Holdsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB33611BD4A606919F343F0639C8719@BN8PR12MB3361.namprd12.prod.outlook.com \
--to=jholdsworth@nvidia.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).