From: Ben Peart <Ben.Peart@microsoft.com>
To: "gitster@pobox.com" <gitster@pobox.com>, Ben Peart <peartben@gmail.com>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Kevin Willford <kewillf@microsoft.com>,
"sandals@crustytoothpaste.net" <sandals@crustytoothpaste.net>
Subject: RE: [PATCH v2] read-cache: add post-indexchanged hook
Date: Fri, 15 Feb 2019 18:02:53 +0000 [thread overview]
Message-ID: <BL0PR2101MB0914080996B40B6240322DD2F4600@BL0PR2101MB0914.namprd21.prod.outlook.com> (raw)
In-Reply-To: <xmqq1s496iwe.fsf@gitster-ct.c.googlers.com>
> -----Original Message-----
> From: Junio C Hamano <jch2355@gmail.com> On Behalf Of Junio C Hamano
> Sent: Friday, February 15, 2019 12:50 PM
> To: Ben Peart <peartben@gmail.com>
> Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>; git@vger.kernel.org;
> Ben Peart <Ben.Peart@microsoft.com>; Kevin Willford
> <kewillf@microsoft.com>; sandals@crustytoothpaste.net
> Subject: Re: [PATCH v2] read-cache: add post-indexchanged hook
>
> Ben Peart <peartben@gmail.com> writes:
>
> > On 2/14/2019 3:33 PM, Junio C Hamano wrote:
> >> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> >>
> >>> On 14/02/2019 14:42, Ben Peart wrote:
> >>>> From: Ben Peart <benpeart@microsoft.com>
> >>>>
> >>>> Add a post-indexchanged hook that is invoked after the index is
> >>>> written in
> >>>
> >>> s/post-indexchanged/post-index-changed/
> >>
> >> Good. I wasn't paying close attention to the previous round, but is
> >> that the only name-related bikeshedding? I somehow feel that without
> >> s/changed/change/ the name does not roll well on my tongue and does
> >> not sit well together with existing ones like post-receive (which is
> >> not post-received). I dunno.
> >>
> >> Will queue. Thanks.
> >
> > Would you like me to submit another version with the above spelling
> > corrections in the commit message or is it easier to fix it up
> > yourself?
>
> I've already done s/indexchanged/index-changed/ before queuing (there
> was only one IIRC in the log message), and also the 'optimize' typofix.
>
> I didn't do anything about dropping 'd' at the end, as I haven't heard any
> feedback on that from anybody yet.
>
I'm ok with either. post-index-changed sounded clearer to me but you're right, none of the other hooks use the post tense. I've submitted one with 'post-index-change' - feel free to keep/user either.
> >>>> do_write_locked_index().
> >>>>
> >>>> This hook is meant primarily for notification, and cannot affect
> >>>> the outcome of git commands that trigger the index write.
> >>>>
> >>>> The hook is passed a flag to indicate whether the working directory
> >>>> was updated or not and a flag indicating if a skip-worktree bit
> >>>> could have changed. These flags enable the hook to optmize its
> >>>> response to the
> >>>
> >>> s/optmize/optimize/
> >>>
> >>> ATB,
> >>> Ramsay Jones
next prev parent reply other threads:[~2019-02-15 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 19:51 [PATCH v1 0/3] Add post-indexchanged hook Ben Peart
2019-02-08 19:51 ` [PATCH v1 1/3] read-cache: add " Ben Peart
2019-02-08 23:53 ` brian m. carlson
2019-02-12 17:39 ` Ben Peart
2019-02-08 19:51 ` [PATCH v1 2/3] read-cache: add test for " Ben Peart
2019-02-08 19:51 ` [PATCH v1 3/3] read-cache: Add documentation for the " Ben Peart
2019-02-14 14:42 ` [PATCH v2] read-cache: add " Ben Peart
2019-02-14 16:28 ` Ramsay Jones
2019-02-14 20:33 ` Junio C Hamano
2019-02-15 0:14 ` Ben Peart
2019-02-15 17:50 ` Junio C Hamano
2019-02-15 18:02 ` Ben Peart [this message]
2019-02-15 17:59 ` [PATCH v3] read-cache: add post-index-change hook Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR2101MB0914080996B40B6240322DD2F4600@BL0PR2101MB0914.namprd21.prod.outlook.com \
--to=ben.peart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kewillf@microsoft.com \
--cc=peartben@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).