From: Ben Peart <peartben@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, benpeart@microsoft.com,
kewillf@microsoft.com
Subject: Re: [PATCH v1 1/3] read-cache: add post-indexchanged hook
Date: Tue, 12 Feb 2019 12:39:56 -0500 [thread overview]
Message-ID: <782f0801-a207-96c9-2f1c-ed7939a9e3a5@gmail.com> (raw)
In-Reply-To: <20190208235317.GI11927@genre.crustytoothpaste.net>
On 2/8/2019 6:53 PM, brian m. carlson wrote:
> On Fri, Feb 08, 2019 at 02:51:13PM -0500, Ben Peart wrote:
>> From: Ben Peart <benpeart@microsoft.com>
>>
>> Add a post-indexchanged hook that is invoked after the index is written in
>> do_write_locked_index().
>>
>> This hook is meant primarily for notification, and cannot affect
>> the outcome of git commands that trigger the index write.
>>
>> Signed-off-by: Ben Peart <benpeart@microsoft.com>
>
> First, I think the tests should be merged into this commit. That's what
> we typically do.
Happy to. In fact, I'd be happy to add the documentation as well and
have a single commit. That's what _I'd_ typically do for something small
like this. :)
>
> I'm also going to bikeshed slightly and suggest "post-index-changed",
> since we normally use dashes between words in our hook names.
>
I can do that as well to help make it more consistent.
>> diff --git a/cache.h b/cache.h
>> index 27fe635f62..46eb862d3e 100644
>> --- a/cache.h
>> +++ b/cache.h
>> @@ -338,7 +338,9 @@ struct index_state {
>> struct cache_time timestamp;
>> unsigned name_hash_initialized : 1,
>> initialized : 1,
>> - drop_cache_tree : 1;
>> + drop_cache_tree : 1,
>> + updated_workdir : 1,
>> + updated_skipworktree : 1;
>
> How important is it that we expose whether the skip-worktree bit is
> changed? I can understand if we expose the workdir is updated, since
> that's a thing a general user of this hook is likely to be interested
> in. However, I'm not sure that for a general-purpose hook, the
> skip-worktree bit is interesting.
>
In our use case, we needed the skip-worktree flag because if something
clears the skip-worktree bit on a file, we need to start paying
attention to it in the work directory. This flag tells us that may have
happened and enables us to not have to do the extra work for other index
changed events that don't change the index without updating the working
directory.
Initially this was just to deal with 'reset --mixed' as it behaves
differently with regards to updating the index and working directory
than most other commands. However, the update-index command can also
arbitrarily clear the skip-worktree bit so we renamed the flag to be
more generic.
>> diff --git a/read-cache.c b/read-cache.c
>> index 0e0c93edc9..0fcfa8a075 100644
>> --- a/read-cache.c
>> +++ b/read-cache.c
>> @@ -17,6 +17,7 @@
>> #include "commit.h"
>> #include "blob.h"
>> #include "resolve-undo.h"
>> +#include "run-command.h"
>> #include "strbuf.h"
>> #include "varint.h"
>> #include "split-index.h"
>> @@ -2999,8 +3000,17 @@ static int do_write_locked_index(struct index_state *istate, struct lock_file *l
>> if (ret)
>> return ret;
>> if (flags & COMMIT_LOCK)
>> - return commit_locked_index(lock);
>> - return close_lock_file_gently(lock);
>> + ret = commit_locked_index(lock);
>> + else
>> + ret = close_lock_file_gently(lock);
>> +
>> + run_hook_le(NULL, "post-indexchanged",
>> + istate->updated_workdir ? "1" : "0",
>> + istate->updated_skipworktree ? "1" : "0", NULL);
>
> I have, in general, some concerns about this API. First, I think we need
> to consider that if we're going to expose various bits of information,
> we might in the future want to expose more such bits. If so, adding
> integer parameters is not likely to be a good way to do this. It's hard
> to remember and if a binary is used as the hook, it may not always
> handle additional arguments gracefully like shell scripts tend to.
>
Binaries deal with a variable number of arguments all the time via `int
argc, const char **argv` so this isn't a problem (we actually use a
binary for this hook already).
> If we're not going to expose the skip-worktree bit, then I suppose one
> argument is fine. Otherwise, it might be better to expose key-value
> pairs on stdin instead, or something like that.
>
I'm not sure what else we may want to add in the future; this is all
we've needed for our uses. For now, I'd suggest we keep it simple and
just pass them as command line parameters like we do with the other
hooks. It's easy to add additional arguments in the future and if we
ever get to where that is unwieldy, we can address it then (YAGNI).
> Finally, I have questions about performance. What's the overhead of
> determining whether the hook exists in this code path when there isn't
> one? Since the index is frequently used, and can be written out as an
> optimization by some commands, it would be nice to keep overhead low if
> the hook isn't present.
>
If you ever hit this code path, we've just updated the index which means
we read the index file, did an lstat() on every file in the repo plus
various refs, config files, etc, and then wrote out a new index file.
Adding one more test for a hooks existence doesn't have any measurable
impact.
Thank you for the feedback!
next prev parent reply other threads:[~2019-02-12 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 19:51 [PATCH v1 0/3] Add post-indexchanged hook Ben Peart
2019-02-08 19:51 ` [PATCH v1 1/3] read-cache: add " Ben Peart
2019-02-08 23:53 ` brian m. carlson
2019-02-12 17:39 ` Ben Peart [this message]
2019-02-08 19:51 ` [PATCH v1 2/3] read-cache: add test for " Ben Peart
2019-02-08 19:51 ` [PATCH v1 3/3] read-cache: Add documentation for the " Ben Peart
2019-02-14 14:42 ` [PATCH v2] read-cache: add " Ben Peart
2019-02-14 16:28 ` Ramsay Jones
2019-02-14 20:33 ` Junio C Hamano
2019-02-15 0:14 ` Ben Peart
2019-02-15 17:50 ` Junio C Hamano
2019-02-15 18:02 ` Ben Peart
2019-02-15 17:59 ` [PATCH v3] read-cache: add post-index-change hook Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782f0801-a207-96c9-2f1c-ed7939a9e3a5@gmail.com \
--to=peartben@gmail.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=kewillf@microsoft.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).