* Problem with git bundle creation
@ 2010-10-13 1:58 Kris Shannon
2010-10-15 16:52 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Kris Shannon @ 2010-10-13 1:58 UTC (permalink / raw)
To: Git Mailing List
git clone git://github.com/freenet/fred-official.git
git bundle create bad.gitbundle -1 build01194
head -2 bad.gitbundle
Problem manifested by a commit message which happens to have a hyphen
in just the wrong place such that git rev-list --boundary
--pretty=oneline has a line which exceeds the 1024 buffer limit that
git bundle is using for reading and happens to read in the rest of the
commit messsage as a boundary commit.
git bundle should probably be checking that the fgets buffer actually
ends in a newline and if it doesn't then slurp in more until it does
(probably discarding it in the process)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Problem with git bundle creation
2010-10-13 1:58 Problem with git bundle creation Kris Shannon
@ 2010-10-15 16:52 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2010-10-15 16:52 UTC (permalink / raw)
To: Kris Shannon; +Cc: Git Mailing List
Kris Shannon wrote:
> git clone git://github.com/freenet/fred-official.git
> git bundle create bad.gitbundle -1 build01194
> head -2 bad.gitbundle
>
> Problem manifested by a commit message which happens to have a hyphen
> in just the wrong place such that git rev-list --boundary
> --pretty=oneline has a line which exceeds the 1024 buffer limit that
> git bundle is using for reading and happens to read in the rest of the
> commit messsage as a boundary commit.
>
> git bundle should probably be checking that the fgets buffer actually
> ends in a newline and if it doesn't then slurp in more until it does
> (probably discarding it in the process)
Sounds like you've tracked down the problem. Care to write a patch?
(Even a placeholder that die()s would be helpful if you don't have
time for the full proposed fix.)
Thanks for reporting.
Jonathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-15 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-13 1:58 Problem with git bundle creation Kris Shannon
2010-10-15 16:52 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).