git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
	git@vger.kernel.org, johan@herland.net, davvid@gmail.com,
	Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH next 2/2] Remove python 2.5'isms
Date: Thu, 10 Jun 2010 09:35:48 +0200	[thread overview]
Message-ID: <AANLkTimLiLfGAMLp0n86eCIQFViu4veu0aTL6yuA_8f1@mail.gmail.com> (raw)
In-Reply-To: <4C1094BF.5070907@drmicha.warpmail.net>

Heya,

On Thu, Jun 10, 2010 at 09:31, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
> Note that due to the use of an iterator (which P2.4 has) rather than a
> list or set, the expression is just as efficient, i.e. calls
> startswith() only as often as necessary.

I like that version a lot better, thanks. And I agree, the check_call
replacement code should just be put into it's own function in a
similar way, and we should use subprocess if it is available.

-- 
Cheers,

Sverre Rabbelier

      reply	other threads:[~2010-06-10  7:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09 21:23 [PATCH next 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-09 21:24 ` [PATCH next 2/2] Remove python 2.5'isms Brandon Casey
2010-06-09 21:28   ` Sverre Rabbelier
2010-06-09 22:40     ` Johan Herland
2010-06-09 22:46       ` Sverre Rabbelier
2010-06-10  0:24       ` [PATCH next 2/2 v2] " Brandon Casey
2010-06-10  7:13         ` Sverre Rabbelier
2010-06-10  9:28         ` Michael J Gruber
2010-06-10 15:41           ` David Ripton
2010-06-11 13:28             ` Michael J Gruber
2010-06-10  7:31     ` [PATCH next 2/2] " Michael J Gruber
2010-06-10  7:35       ` Sverre Rabbelier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimLiLfGAMLp0n86eCIQFViu4veu0aTL6yuA_8f1@mail.gmail.com \
    --to=srabbelier@gmail.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=davvid@gmail.com \
    --cc=drafnel@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).