From: Michael J Gruber <git@drmicha.warpmail.net>
To: Brandon Casey <casey@nrlssc.navy.mil>,
johan@herland.net, git@vger.kernel.org, srabbelier@gmail.com,
davvid@gmail.com, Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH next 2/2 v2] Remove python 2.5'isms
Date: Fri, 11 Jun 2010 15:28:48 +0200 [thread overview]
Message-ID: <4C123A10.6050103@drmicha.warpmail.net> (raw)
In-Reply-To: <20100610154114.GC31213@vidar.dreamhost.com>
David Ripton venit, vidit, dixit 10.06.2010 17:41:
> On 2010.06.10 11:28:15 +0200, Michael J Gruber wrote:
>> Doesn't P2.4 have
>>
>> from hashlib import sha1 as _digest
>>
>> etc.? I haven't checked for "as".
>
> Hashlib was new in Python 2.5. See the note at the top of:
> http://docs.python.org/library/hashlib.html
>
> You may have hashlib in your Python 2.4, but if so it's a third-party
> module, not part of the standard library. You shouldn't rely on
> everyone having it, when it's so easy to fallback to the sha module.
Well sure, that's why we need the try/except's.
>
> "import foo as bar" was added in Python 2.0. "as" became a reserved
> word in Python 2.6.
Thanks!. Then we can use the clean version as suggested above (inside
try/except).
Michael
next prev parent reply other threads:[~2010-06-11 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 21:23 [PATCH next 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-09 21:24 ` [PATCH next 2/2] Remove python 2.5'isms Brandon Casey
2010-06-09 21:28 ` Sverre Rabbelier
2010-06-09 22:40 ` Johan Herland
2010-06-09 22:46 ` Sverre Rabbelier
2010-06-10 0:24 ` [PATCH next 2/2 v2] " Brandon Casey
2010-06-10 7:13 ` Sverre Rabbelier
2010-06-10 9:28 ` Michael J Gruber
2010-06-10 15:41 ` David Ripton
2010-06-11 13:28 ` Michael J Gruber [this message]
2010-06-10 7:31 ` [PATCH next 2/2] " Michael J Gruber
2010-06-10 7:35 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C123A10.6050103@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=casey@nrlssc.navy.mil \
--cc=davvid@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).