From: Dan McGee <dpmcgee@gmail.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] diff_tree_sha1: skip diff_tree if old == new
Date: Thu, 31 Mar 2011 08:56:11 -0500 [thread overview]
Message-ID: <AANLkTi=sShiwiRMF+cgiWimO80FBRKNmskwTb4JYZeSG@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinwovtXfm-OvVivwyjs2RT8+D6Mj=OXkQCNH8uy@mail.gmail.com>
On Thu, Mar 31, 2011 at 7:58 AM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
> On Thu, Mar 31, 2011 at 8:37 AM, Dan McGee <dpmcgee@gmail.com> wrote:
>> These next few patches are all derived from trying to make operations on this
>> repository a bit faster:
>> http://projects.archlinux.org/svntogit/packages.git/
>>
>> ...
>>
>> time git log -- zzzzz_not_exist >/dev/null
>> 35.558s 0.976s
>
> Do you have numbers before and after applying this series? It'd be
> interesting to see how much we gain from the series.
Whipped some up for you:
Repo Operation master after delta
arch-packages ../git/git-log 2.26 2.27 -0.01
arch-packages ../git/git-log -- zzzzz_not_exist 34.69 26.75 7.93
arch-packages ../git/git-log -- aaaaa_first 6.02 5.76 0.26
linux-2.6 ../git/git-log 5.51 5.50 0.02
linux-2.6 ../git/git-log -- zzzzz_not_exist 0.95 0.92 0.03
linux-2.6 ../git/git-log -- aaaaa_first 0.89 0.86 0.03
These are all the "real" value from time with the full set of patches
applied. As you can see, one either gains or isn't really affected by
these; anything under 0.05s delta is noise.
Bigger gains than this don't seem too plausible unless we move away
from linear parsing and traversal of tree objects.
-Dan
next prev parent reply other threads:[~2011-03-31 13:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 1:37 [PATCH 1/5] diff_tree_sha1: skip diff_tree if old == new Dan McGee
2011-03-31 1:37 ` [PATCH 2/5] tree-walk: drop unused parameter from match_dir_prefix Dan McGee
2011-08-30 18:55 ` Dan McGee
2011-03-31 1:37 ` [PATCH 3/5] tree-walk: micro-optimization in tree_entry_interesting Dan McGee
2011-04-03 4:01 ` Nguyen Thai Ngoc Duy
2011-04-03 18:55 ` Junio C Hamano
2011-04-05 0:22 ` Dan McGee
[not found] ` <CAEik5nOKrpFycZYVnSu4_5LYWxn0JS_hVXyiQH-80Bu-C4k8VQ@mail.gmail.com>
2011-08-30 19:51 ` Dan McGee
2011-08-30 20:40 ` Junio C Hamano
2011-09-09 2:02 ` [PATCH 1/2] tree-walk: drop unused parameter from match_dir_prefix Dan McGee
2011-09-09 2:02 ` [PATCH 2/2] tree-walk: micro-optimization in tree_entry_interesting Dan McGee
2011-04-04 14:46 ` [PATCH] tree_entry_interesting: inline strncmp() Nguyễn Thái Ngọc Duy
2011-03-31 1:38 ` [PATCH 4/5] tree-walk: unroll get_mode since loop boundaries are well-known Dan McGee
2011-04-02 9:28 ` Nguyen Thai Ngoc Duy
2011-04-02 17:28 ` Dan McGee
2011-04-03 4:07 ` Nguyen Thai Ngoc Duy
2011-04-04 10:29 ` Erik Faye-Lund
2011-04-04 12:30 ` Andreas Ericsson
2011-04-04 16:55 ` Junio C Hamano
2011-04-05 5:33 ` Dan McGee
2011-04-05 23:55 ` Antriksh Pany
2011-04-06 20:45 ` Dan McGee
2011-03-31 1:38 ` [PATCH 5/5] tree-walk: match_entry microoptimization Dan McGee
2011-04-02 9:06 ` Nguyen Thai Ngoc Duy
2011-04-02 17:54 ` Dan McGee
2011-03-31 12:58 ` [PATCH 1/5] diff_tree_sha1: skip diff_tree if old == new Nguyen Thai Ngoc Duy
2011-03-31 13:56 ` Dan McGee [this message]
2011-04-01 22:28 ` Junio C Hamano
[not found] ` <AANLkTinPSqDPdGi5nA3sH1D2wMSW1SQc+5gRqdLy++y0@mail.gmail.com>
2011-04-02 18:38 ` Fwd: " Dan McGee
2011-05-03 7:34 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=sShiwiRMF+cgiWimO80FBRKNmskwTb4JYZeSG@mail.gmail.com' \
--to=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).