From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2
Date: Mon, 16 Aug 2010 02:01:07 +0000 [thread overview]
Message-ID: <AANLkTi=otHzT0n6Do0EzBMMbb0dyh8C6O0G+KpJjtAhg@mail.gmail.com> (raw)
In-Reply-To: <7vaaonfhs8.fsf@alter.siamese.dyndns.org>
On Mon, Aug 16, 2010 at 01:49, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>>> + # Needs an unrelated root commit
>>>> + test_commit README &&
>>>
>>> This is not a "root" commit, is it?
>>
>> s/root/first/
>
> It is not even the first commit, is it? It comes on top of whatever
> commits that earlier tests left.
>
>>>> + >Foo.bar &&
>>>> + git add Foo.bar &&
>>>> + git commit --allow-empty-message </dev/null &&
>>>
>>> Does emptiness of the message matter?
>>
>> No, I was just going for a minimal test case, no commit message is
>> more minimal than having one.
>
> I do not think having to write "--allow-empty-message </dev/null" is
> aiming for being minimal; it is doing something unusual after all.
>
> If you do not remember why you added this test 6 months down the road,
> wouldn't you be confused to think maybe the commit has to be unusual in
> that it has to lack the message to trigger the bug?
My v2 patch should address both of these issues.
next prev parent reply other threads:[~2010-08-16 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 11:25 BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov
2010-08-13 13:38 ` Ævar Arnfjörð Bjarmason
2010-08-13 17:36 ` Junio C Hamano
2010-08-13 17:53 ` Linus Torvalds
2010-08-13 19:12 ` Junio C Hamano
2010-08-13 19:46 ` [PATCH] diff --follow: do call diffcore_std() as necessary Junio C Hamano
2010-08-13 21:27 ` Ævar Arnfjörð Bjarmason
2010-08-13 22:46 ` Junio C Hamano
2010-08-14 1:10 ` [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2 Ævar Arnfjörð Bjarmason
2010-08-14 1:19 ` Ævar Arnfjörð Bjarmason
2010-08-15 9:08 ` Junio C Hamano
2010-08-15 9:24 ` Ævar Arnfjörð Bjarmason
2010-08-16 1:49 ` Junio C Hamano
2010-08-16 2:01 ` Ævar Arnfjörð Bjarmason [this message]
2010-08-15 10:16 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-08-17 14:48 ` BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=otHzT0n6Do0EzBMMbb0dyh8C6O0G+KpJjtAhg@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).