From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Bo Yang <struggleyb.nku@gmail.com>,
Constantine Plotnikov <constantine.plotnikov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] diff --follow: do call diffcore_std() as necessary
Date: Fri, 13 Aug 2010 15:46:39 -0700 [thread overview]
Message-ID: <7vzkwqi10w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <AANLkTin-qPe-meW_kV5vtC0BT8QS-sZ90BrckRAbjk9X@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri\, 13 Aug 2010 21\:27\:38 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Fri, Aug 13, 2010 at 19:46, Junio C Hamano <gitster@pobox.com> wrote:
>
>> This hopefully fixes the breakage.
>
> Hopefully. It'd also be nice if we had a regression test for this, but
> I don't know how hard that would be to arrange. If it's hard to
> reproduce we might get away with a filter-branch + subdir filter from
> the idea repository.
As I wrote, the test added by 0cdca13 breaks with just a reversion of
1da6175 but with this patch it passes. I didn't run any other test,
though ;-).
next prev parent reply other threads:[~2010-08-13 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 11:25 BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov
2010-08-13 13:38 ` Ævar Arnfjörð Bjarmason
2010-08-13 17:36 ` Junio C Hamano
2010-08-13 17:53 ` Linus Torvalds
2010-08-13 19:12 ` Junio C Hamano
2010-08-13 19:46 ` [PATCH] diff --follow: do call diffcore_std() as necessary Junio C Hamano
2010-08-13 21:27 ` Ævar Arnfjörð Bjarmason
2010-08-13 22:46 ` Junio C Hamano [this message]
2010-08-14 1:10 ` [PATCH] log: test for regression introduced in v1.7.2-rc0~103^2~2 Ævar Arnfjörð Bjarmason
2010-08-14 1:19 ` Ævar Arnfjörð Bjarmason
2010-08-15 9:08 ` Junio C Hamano
2010-08-15 9:24 ` Ævar Arnfjörð Bjarmason
2010-08-16 1:49 ` Junio C Hamano
2010-08-16 2:01 ` Ævar Arnfjörð Bjarmason
2010-08-15 10:16 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-08-17 14:48 ` BUG: git log: fatal: internal error in diff-resolve-rename-copy Constantine Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzkwqi10w.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=constantine.plotnikov@gmail.com \
--cc=git@vger.kernel.org \
--cc=struggleyb.nku@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).