From: Philip Oakley <philipoakley@iee.email>
To: Junio C Hamano <gitster@pobox.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Edmundo Carmona Antoranz <eantoranz@gmail.com>,
whydoubt@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v2] blame: report correct number of lines in progress when using ranges
Date: Fri, 8 Apr 2022 09:03:55 +0100 [thread overview]
Message-ID: <9920b355-9003-e7c7-77ab-3432651674e9@iee.email> (raw)
In-Reply-To: <xmqqsfqq1bx9.fsf@gitster.g>
On 06/04/2022 16:14, Junio C Hamano wrote:
> Philip Oakley <philipoakley@iee.email> writes:
>
>> On 05/04/2022 08:34, Bagas Sanjaya wrote:
>>> On 05/04/22 01.21, Edmundo Carmona Antoranz wrote:
>>>> When using ranges, use their sizes as the limit for progress
>>>> instead of the size of the full file.
>>> The progress limit is defined by number of affected lines, right?
>> I'd also wondered about 'their', thinking it was 'the files', rather
>> than 'the ranges' [within those files].
>>
>> perhaps: s/their/range/
> I actually think that it is obvious that "their" refers to the
> ranges and not the file. Between "the ranges" and "the file", only
> the former is plural that "their" could possibly refer to. Also,
> "instead ... the full file" makes the sentence nonsensical if it
> referred to the "file"---"we must use the number of lines in the
> file, instead of the number of lines in the file" simply would not
> make much sense.
I'm on the 'context and guidelines' side of English comprehension, so it
was all about files being blamed.
>
> But I do not object to being more explicit.
The core point though was that it can be misunderstood, thus avoiding
the indirection, as you say, makes it more explicit for the reader.
>
>> "When using ranges, use the range sizes as the limit for progress' ..
--
Philip
next prev parent reply other threads:[~2022-04-08 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 18:21 [PATCH v2] blame: report correct number of lines in progress when using ranges Edmundo Carmona Antoranz
2022-04-04 18:25 ` Edmundo Carmona Antoranz
2022-04-04 19:32 ` Junio C Hamano
2022-04-05 7:34 ` Bagas Sanjaya
2022-04-05 7:46 ` Ævar Arnfjörð Bjarmason
2022-04-05 7:55 ` Edmundo Carmona Antoranz
2022-04-05 9:42 ` Philip Oakley
2022-04-06 15:14 ` Junio C Hamano
2022-04-08 8:03 ` Philip Oakley [this message]
2022-04-08 18:16 ` Junio C Hamano
2022-04-05 9:36 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9920b355-9003-e7c7-77ab-3432651674e9@iee.email \
--to=philipoakley@iee.email \
--cc=bagasdotme@gmail.com \
--cc=eantoranz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=whydoubt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).