From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-5.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 423181F4CE for ; Fri, 8 Apr 2022 08:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbiDHIGI (ORCPT ); Fri, 8 Apr 2022 04:06:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbiDHIGG (ORCPT ); Fri, 8 Apr 2022 04:06:06 -0400 Received: from smtp.hosts.co.uk (smtp.hosts.co.uk [85.233.160.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 432EC25E87 for ; Fri, 8 Apr 2022 01:04:00 -0700 (PDT) Received: from host-84-13-159-41.opaltelecom.net ([84.13.159.41] helo=[192.168.1.37]) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1ncjb3-000BNM-8W; Fri, 08 Apr 2022 09:03:57 +0100 Message-ID: <9920b355-9003-e7c7-77ab-3432651674e9@iee.email> Date: Fri, 8 Apr 2022 09:03:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] blame: report correct number of lines in progress when using ranges Content-Language: en-GB To: Junio C Hamano Cc: Bagas Sanjaya , Edmundo Carmona Antoranz , whydoubt@gmail.com, git@vger.kernel.org References: <20220404182129.33992-1-eantoranz@gmail.com> <8622e48c-9f34-c644-4016-02c3795ac1e9@iee.email> From: Philip Oakley In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 06/04/2022 16:14, Junio C Hamano wrote: > Philip Oakley writes: > >> On 05/04/2022 08:34, Bagas Sanjaya wrote: >>> On 05/04/22 01.21, Edmundo Carmona Antoranz wrote: >>>> When using ranges, use their sizes as the limit for progress >>>> instead of the size of the full file. >>> The progress limit is defined by number of affected lines, right? >> I'd also wondered about 'their', thinking it was 'the files', rather >> than 'the ranges' [within those files]. >> >> perhaps: s/their/range/ > I actually think that it is obvious that "their" refers to the > ranges and not the file. Between "the ranges" and "the file", only > the former is plural that "their" could possibly refer to. Also, > "instead ... the full file" makes the sentence nonsensical if it > referred to the "file"---"we must use the number of lines in the > file, instead of the number of lines in the file" simply would not > make much sense. I'm on the 'context and guidelines' side of English comprehension, so it was all about files being blamed. > > But I do not object to being more explicit. The core point though was that it can be misunderstood, thus avoiding the indirection, as you say, makes it more explicit for the reader. > >> "When using ranges, use the range sizes as the limit for progress' .. -- Philip