git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthew DeVore <matvore@comcast.net>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2018, #06; Wed, 21)
Date: Wed, 5 Dec 2018 14:04:02 -0800	[thread overview]
Message-ID: <93b57fe5-1cd4-9213-7183-47f695876615@comcast.net> (raw)
In-Reply-To: <xmqqlg5m7qlb.fsf@gitster-ct.c.googlers.com>



On 11/21/2018 01:00 AM, Junio C Hamano wrote:
> * md/list-lazy-objects-fix (2018-10-29) 1 commit
>   - list-objects.c: don't segfault for missing cmdline objects
> 
>   "git rev-list --exclude-promissor-objects" had to take an object
>   that does not exist locally (and is lazily available) from the
>   command line without barfing, but the code dereferenced NULL.
> 
>   That sympotom may be worth addressing, but I think the "fix" is
>   overly broad and is wrong.  Giving a missing object should be
>   diagnosed as an error, not swept under the rug silently.

Thank you for taking a look. I just sent v3 of the patch: 
https://public-inbox.org/git/20181205214346.106217-1-matvore@google.com/T/#u

which is different from v2 in that it honors the presence or absence of 
--ignore-missing. It will only sweep things under the rug if that flag 
is passed.

      parent reply	other threads:[~2018-12-05 22:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21  9:00 What's cooking in git.git (Nov 2018, #06; Wed, 21) Junio C Hamano
2018-11-21 10:48 ` Ævar Arnfjörð Bjarmason
2018-11-22 17:53   ` Jeff King
2018-11-22 18:36     ` Ævar Arnfjörð Bjarmason
2018-11-24 12:09       ` Jeff King
2018-11-25  2:02         ` Junio C Hamano
2018-11-26 18:13           ` Jeff King
2018-11-24  2:11     ` Junio C Hamano
2018-11-24 12:06       ` Jeff King
2018-11-21 20:11 ` js/vsts-ci, was " Johannes Schindelin
2018-11-21 23:54 ` Stephen P. Smith
2018-11-22  1:06   ` Junio C Hamano
2018-11-22  2:08     ` Stephen P. Smith
2018-11-22 16:05       ` Linus Torvalds
2018-11-22 10:48   ` Ævar Arnfjörð Bjarmason
2018-11-26 21:57 ` Stefan Beller
2018-11-26 23:34   ` Junio C Hamano
2018-12-05 22:04 ` Matthew DeVore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b57fe5-1cd4-9213-7183-47f695876615@comcast.net \
    --to=matvore@comcast.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).