From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>
Subject: Re: What's cooking in git.git (Nov 2018, #06; Wed, 21)
Date: Mon, 26 Nov 2018 13:13:20 -0500 [thread overview]
Message-ID: <20181126181320.GA32492@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqpnut29uq.fsf@gitster-ct.c.googlers.com>
On Sun, Nov 25, 2018 at 11:02:05AM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I do also think in the long run we should be fixing the "unreachable
> > always become loose" issues.
>
> I think I've seen an idea of collecting them into a garbage pack
> floated for at least a few times here. What are the downsides? We
> no longer will know when these unreachable ones were last accessed
> individually so we need to come up with a different policy around
> their expiration? As the common traits among objects in such a
> garbage pack (iow the way we discover the objects that need to be
> placed in there) does not involve path information and we lose the
> ability to compress them well?
Yes, the main issue is handling the expiration/mtime.
We may lose some input to the delta heuristics, but:
- the current alternative is non-delta loose objects (so just shoving
those in a pack is no worse for disk space, and probably better
because of less inode/file overhead)
- if they were already packed we can often just retain the existing
deltas (and we get this basically for free with the existing code)
- we could still walk unreachable bits of the graph, starting at
dangling commits, to find the path information (we do this to some
degree already to avoid dropping objects depended on by "unreachable
but recent" objects, but I don't know how systematic we are about
making sure to hit walk down from root trees first)
The most thorough discussion I know of in this direction is the one
around:
https://public-inbox.org/git/20170610080626.sjujpmgkli4muh7h@sigill.intra.peff.net/
-Peff
next prev parent reply other threads:[~2018-11-26 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 9:00 What's cooking in git.git (Nov 2018, #06; Wed, 21) Junio C Hamano
2018-11-21 10:48 ` Ævar Arnfjörð Bjarmason
2018-11-22 17:53 ` Jeff King
2018-11-22 18:36 ` Ævar Arnfjörð Bjarmason
2018-11-24 12:09 ` Jeff King
2018-11-25 2:02 ` Junio C Hamano
2018-11-26 18:13 ` Jeff King [this message]
2018-11-24 2:11 ` Junio C Hamano
2018-11-24 12:06 ` Jeff King
2018-11-21 20:11 ` js/vsts-ci, was " Johannes Schindelin
2018-11-21 23:54 ` Stephen P. Smith
2018-11-22 1:06 ` Junio C Hamano
2018-11-22 2:08 ` Stephen P. Smith
2018-11-22 16:05 ` Linus Torvalds
2018-11-22 10:48 ` Ævar Arnfjörð Bjarmason
2018-11-26 21:57 ` Stefan Beller
2018-11-26 23:34 ` Junio C Hamano
2018-12-05 22:04 ` Matthew DeVore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126181320.GA32492@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).