git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Taylor Blau <me@ttaylorr.com>, Elijah Newren <newren@gmail.com>
Cc: Pratyush Yadav <me@yadavpratyush.com>,
	Phillip Wood <phillip.wood@dunelm.org.uk>,
	Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] checkout: add simple check for 'git checkout -b'
Date: Fri, 30 Aug 2019 12:56:44 -0400	[thread overview]
Message-ID: <8bf76fcf-539c-6fea-170e-61fc81822ef0@gmail.com> (raw)
In-Reply-To: <20190830004339.GA34082@syl.lan>

On 8/29/2019 8:43 PM, Taylor Blau wrote:
> Hi Elijah,
> 
> On Thu, Aug 29, 2019 at 05:19:44PM -0700, Elijah Newren wrote:
>> Personally, although I understand the desire to support any possible
>> cases in general, *this is a performance hack*.  As such, it should be
>> as simple and localized as possible.  I don't think supporting
>> old-style stuck flags (-b$BRANCH) is worth complicating this.  I'm
>> even leery of adding support for --track (do any users of huge repos
>> use -b with --track?  Does anyone at all use --track anymore?  I'm not
>> sure I've ever seen any user use that flag in the last 10 years other
>> than myself.)  Besides, in the *worst* possible case, the command the
>> user specifies works just fine...it just takes a little longer.  My
>> opinion is that Stolee's patch is perfect as-is and should not be
>> generalized at all.
> 
> I wholeheartedly agree with this, and pledge my $.02 towards it as well.
> Now with a combined total of $.04, I think that this patch is ready for
> queueing as-is.

Thanks, both!


  reply	other threads:[~2019-08-30 16:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 17:01 [PATCH 0/1] checkout: add simple check for 'git checkout -b' Derrick Stolee via GitGitGadget
2019-08-29 17:01 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-08-29 17:25   ` Elijah Newren
2019-08-29 18:54   ` Phillip Wood
2019-08-29 20:07     ` Derrick Stolee
2019-08-29 20:30       ` Pratyush Yadav
2019-08-29 21:40         ` Pratyush Yadav
2019-08-30  0:19           ` Elijah Newren
2019-08-30  0:43             ` Taylor Blau
2019-08-30 16:56               ` Derrick Stolee [this message]
2019-08-30 17:18               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bf76fcf-539c-6fea-170e-61fc81822ef0@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=me@yadavpratyush.com \
    --cc=newren@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).