Re: [PATCH 1/1] checkout: add simple check for 'git checkout -b'

git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed

From: Derrick Stolee <stolee@gmail.com>
To: phillip.wood@dunelm.org.uk,
	Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 1/1] checkout: add simple check for 'git checkout -b'
Date: Thu, 29 Aug 2019 16:07:38 -0400	[thread overview]
Message-ID: <206819d0-8066-e8e8-8967-8a1db05eea26@gmail.com> (raw)
In-Reply-To: <7e406b35-9ff6-348f-bdee-7540381f000e@gmail.com>

On 8/29/2019 2:54 PM, Phillip Wood wrote:
> Hi Stolee
> 
> On 29/08/2019 18:01, Derrick Stolee via GitGitGadget wrote:
>> +   
>> +    if (argc == 3 && !strcmp(argv[1], "-b")) {
>> +        /*
>> +         * User ran 'git checkout -b <branch>' and expects
> 
> What if the user ran 'git checkout -b<branch>'? Then argc == 2.

Good catch. I'm tempted to say "don't do that" to keep this
simple. They won't have incorrect results, just slower than
the "with space" option.

However, if there is enough interest in correcting the "-b<branch>"
case, then I can make another attempt at this.

-Stolee

next prev parent reply	other threads:[~2019-08-29 20:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 17:01 [PATCH 0/1] checkout: add simple check for 'git checkout -b' Derrick Stolee via GitGitGadget
2019-08-29 17:01 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-08-29 17:25   ` Elijah Newren
2019-08-29 18:54   ` Phillip Wood
2019-08-29 20:07     ` Derrick Stolee [this message]
2019-08-29 20:30       ` Pratyush Yadav
2019-08-29 21:40         ` Pratyush Yadav
2019-08-30  0:19           ` Elijah Newren
2019-08-30  0:43             ` Taylor Blau
2019-08-30 16:56               ` Derrick Stolee
2019-08-30 17:18               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=206819d0-8066-e8e8-8967-8a1db05eea26@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).