From: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 4/4] imap-send: use curl by default
Date: Mon, 7 Aug 2017 19:10:46 +0200 [thread overview]
Message-ID: <890d4028-1351-a7b9-1797-cf419d5f01e8@morey-chaisemartin.com> (raw)
In-Reply-To: <CAN0heSoRXX_9-yzFf=2Obj_5WosLwK4UtrFrLsw8asdUea1+Yg@mail.gmail.com>
Le 07/08/2017 à 18:37, Martin Ågren a écrit :
> On 7 August 2017 at 16:04, Nicolas Morey-Chaisemartin
> <nicolas@morey-chaisemartin.com> wrote:
>> Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
>> ---
>> imap-send.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/imap-send.c b/imap-send.c
>> index 90b8683ed..4ebc16437 100644
>> --- a/imap-send.c
>> +++ b/imap-send.c
>> @@ -35,13 +35,7 @@ typedef void *SSL;
>> #include "http.h"
>> #endif
>>
>> -#if defined(USE_CURL_FOR_IMAP_SEND) && defined(NO_OPENSSL)
>> -/* only available option */
>> #define USE_CURL_DEFAULT 1
>> -#else
>> -/* strictly opt in */
>> -#define USE_CURL_DEFAULT 0
>> -#endif
>>
>> static int verbosity;
>> static int use_curl = USE_CURL_DEFAULT;
> So this is now basically "static int use_curl = 1;".
>
> Do we need a compile-time escape-hatch in case someone really needs
> to avoid curl, e.g., because they have a too old version? I suppose
> there is a conceptual difference between the "default", i.e., the value
> of USE_CURL_DEFAULT that is assigned to "use_curl", and the "default
> default", i.e., the value that is normally assigned to USE_CURL_DEFAULT.
>
> Martin
The curl code depends on USE_CURL_FOR_IMAP_SEND so even with use_curl == 1, it won't be an issue for people without curl (or old one).
I wasn't sure whether to drop the define or not and figure it might be worth keeping in case in change in the future for some reason.
I don't mind dropping it and hardcofing the default to 1
Also on a side note, I have a case where authentication works with --no-curl but fails withs --curl. Still trying to figure out why.
Nicolas
next prev parent reply other threads:[~2017-08-07 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c74c8c386f2c2d8b6cebd4addf925d0121986067.1502114584.git.nicolas@morey-chaisemartin.com>
2017-08-07 14:03 ` [PATCH 2/4] imap_send: setup_curl: prompt user for username/password if not set in config file Nicolas Morey-Chaisemartin
2017-08-07 14:04 ` [PATCH 3/4] imap_send: setup_curl: use server_conf parameter instead of the global variable Nicolas Morey-Chaisemartin
2017-08-07 16:34 ` Martin Ågren
2017-08-07 17:06 ` Nicolas Morey-Chaisemartin
2017-08-07 19:50 ` Jeff King
2017-08-07 14:04 ` [PATCH 4/4] imap-send: use curl by default Nicolas Morey-Chaisemartin
2017-08-07 16:37 ` Martin Ågren
2017-08-07 17:10 ` Nicolas Morey-Chaisemartin [this message]
2017-08-07 17:37 ` Martin Ågren
2017-08-07 20:01 ` Jeff King
2017-09-12 6:46 ` Junio C Hamano
2017-09-12 7:02 ` Junio C Hamano
2017-09-12 8:24 ` Nicolas Morey-Chaisemartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=890d4028-1351-a7b9-1797-cf419d5f01e8@morey-chaisemartin.com \
--to=nicolas@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).