From: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] imap_send: setup_curl: use server_conf parameter instead of the global variable
Date: Mon, 7 Aug 2017 19:06:07 +0200 [thread overview]
Message-ID: <71817815-4e52-4623-b226-bbb57ca08047@morey-chaisemartin.com> (raw)
In-Reply-To: <CAN0heSqyiisjWyDBXLJcyx=Hh3NA562DoFqP8rpFyi_zuGKLEA@mail.gmail.com>
Le 07/08/2017 à 18:34, Martin Ågren a écrit :
> On 7 August 2017 at 16:04, Nicolas Morey-Chaisemartin
> <nicolas@morey-chaisemartin.com> wrote:
>> Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
>> ---
>> imap-send.c | 24 ++++++++++++------------
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/imap-send.c b/imap-send.c
>> index 682a06551..90b8683ed 100644
>> --- a/imap-send.c
>> +++ b/imap-send.c
>> @@ -1415,37 +1415,37 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
>> if (!curl)
>> die("curl_easy_init failed");
>>
>> - server_fill_credential(&server);
>> - curl_easy_setopt(curl, CURLOPT_USERNAME, server.user);
>> - curl_easy_setopt(curl, CURLOPT_PASSWORD, server.pass);
>> + server_fill_credential(srvc);
>> + curl_easy_setopt(curl, CURLOPT_USERNAME, srvc->user);
>> + curl_easy_setopt(curl, CURLOPT_PASSWORD, srvc->pass);
> Here you change the server_fill_credential-call that you just added.
> Maybe do this patch earlier, perhaps even as patch 1?
>
> I'm snipping lots of s/server/srvc/-changes... There's a less noisy
> way of addressing the fact that srvc is unused: dropping it. I'm not
> saying that's a good idea, but it could be considered, then explained
> why this approach is better. There are some other functions which
> access "server" directly, and some which take (and use!) a "srvc".
> Maybe make the whole file consistent?
>
> Martin
That's why I applied it after #2. I was not sure if this one made sense or not. And it can be dropped with the rest of the series still applying.
I don't know what is the right approach here. Someone with more knowledge of why there is a mix of global variable and local can maybe help ?
Nicolas
next prev parent reply other threads:[~2017-08-07 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c74c8c386f2c2d8b6cebd4addf925d0121986067.1502114584.git.nicolas@morey-chaisemartin.com>
2017-08-07 14:03 ` [PATCH 2/4] imap_send: setup_curl: prompt user for username/password if not set in config file Nicolas Morey-Chaisemartin
2017-08-07 14:04 ` [PATCH 3/4] imap_send: setup_curl: use server_conf parameter instead of the global variable Nicolas Morey-Chaisemartin
2017-08-07 16:34 ` Martin Ågren
2017-08-07 17:06 ` Nicolas Morey-Chaisemartin [this message]
2017-08-07 19:50 ` Jeff King
2017-08-07 14:04 ` [PATCH 4/4] imap-send: use curl by default Nicolas Morey-Chaisemartin
2017-08-07 16:37 ` Martin Ågren
2017-08-07 17:10 ` Nicolas Morey-Chaisemartin
2017-08-07 17:37 ` Martin Ågren
2017-08-07 20:01 ` Jeff King
2017-09-12 6:46 ` Junio C Hamano
2017-09-12 7:02 ` Junio C Hamano
2017-09-12 8:24 ` Nicolas Morey-Chaisemartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71817815-4e52-4623-b226-bbb57ca08047@morey-chaisemartin.com \
--to=nicolas@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).