From: "Andrew Berry" <andrew@furrypaws.ca>
To: gitster@pobox.com
Cc: git@vger.kernel.org, "Bagas Sanjaya" <bagasdotme@gmail.com>
Subject: Re: [PATCH] docs: .gitignore in parents is current repo only
Date: Mon, 05 Jul 2021 13:30:50 -0400 [thread overview]
Message-ID: <889D9AD1-1114-49B4-ADB0-BF78160743E4@furrypaws.ca> (raw)
In-Reply-To: <b9da43a8-897b-7cce-ecbc-ea56078f0f09@gmail.com>
On 2 Jul 2021, at 20:06, Junio C Hamano wrote:
> I would have thought that "up to the toplevel of the work
> tree" would be sufficiently clear where the upward traversal of the
> directories ends, i.e. at the repository boundary.
Seems reasonable. What if we move that note to come after "any parent
directory"?
On 2 Jul 2021, at 20:21, Bagas Sanjaya wrote:
> So for example I have `something/foo` in ../.gitignore, but .gitignore
> (in current directory `something`) has `foo`. Is .gitignore from
> current directory or ../.gitignore takes effect?
In this case, both rules resolve to the same path, so I don't think it
matters? But in practice I'd expect it to be `something/.gitignore`,
since you can negate the pattern from the parent ignore file.
> Also s/toplevel/top level/
That showed up in the diff due to word wrapping. If no other changes are
accepted, I'll file a followup after to get this fixed on it's own.
next prev parent reply other threads:[~2021-07-05 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 22:20 [PATCH] docs: .gitignore in parents is current repo only Andrew Berry
2021-07-03 0:06 ` Junio C Hamano
2021-07-03 0:21 ` Bagas Sanjaya
2021-07-05 17:30 ` Andrew Berry [this message]
2021-07-05 19:59 ` Junio C Hamano
2021-07-05 23:50 ` Andrew Berry
2021-07-06 16:18 ` Junio C Hamano
2021-07-06 20:54 ` [PATCH] docs: .gitignore parsing is to the top of the repo Andrew Berry
2021-07-06 20:57 ` Andrew Berry
2021-07-06 21:57 ` Junio C Hamano
2021-07-07 0:18 ` Junio C Hamano
2021-07-07 0:32 ` Andrew Berry
2021-07-07 1:20 ` Junio C Hamano
2021-07-18 14:12 ` Andrew Berry
2021-07-19 18:36 ` Junio C Hamano
2021-07-06 21:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889D9AD1-1114-49B4-ADB0-BF78160743E4@furrypaws.ca \
--to=andrew@furrypaws.ca \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).