git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Andrew Berry" <andrew@furrypaws.ca>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Bagas Sanjaya" <bagasdotme@gmail.com>
Subject: Re: [PATCH] docs: .gitignore in parents is current repo only
Date: Mon, 05 Jul 2021 19:50:19 -0400	[thread overview]
Message-ID: <54FBABC9-2BDF-4879-AB5A-BAE4E8179D80@furrypaws.ca> (raw)
In-Reply-To: <xmqq4kd8mt05.fsf@gitster.g>

On 5 Jul 2021, at 15:59, Junio C Hamano wrote:

> "Andrew Berry" <andrew@furrypaws.ca> writes:
>
> Meaning something like the following?
>
> I do agree that it makes it a lot clearer.
>
>  Documentation/gitignore.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git c/Documentation/gitignore.txt w/Documentation/gitignore.txt
> index 53e7d5c914..58c2e41bbe 100644
> --- c/Documentation/gitignore.txt
> +++ w/Documentation/gitignore.txt
> @@ -27,8 +27,8 @@ precedence, the last matching pattern decides the 
> outcome):
>     them.
>
>   * Patterns read from a `.gitignore` file in the same directory
> -   as the path, or in any parent directory, with patterns in the
> -   higher level files (up to the toplevel of the work tree) being 
> overridden
> +   as the path, or in any parent directory (up to the toplevel of
> +   the work tree), with patterns in the higher level files being 
> overridden
>     by those in lower level files down to the directory containing the 
> file.
>     These patterns match relative to the location of the
>     `.gitignore` file.  A project normally includes such

Yes, that's good. My only suggestion would mirror the earlier one, to 
split toplevel to "top-level" or "top level".

  reply	other threads:[~2021-07-05 23:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 22:20 [PATCH] docs: .gitignore in parents is current repo only Andrew Berry
2021-07-03  0:06 ` Junio C Hamano
2021-07-03  0:21 ` Bagas Sanjaya
2021-07-05 17:30   ` Andrew Berry
2021-07-05 19:59     ` Junio C Hamano
2021-07-05 23:50       ` Andrew Berry [this message]
2021-07-06 16:18         ` Junio C Hamano
2021-07-06 20:54           ` [PATCH] docs: .gitignore parsing is to the top of the repo Andrew Berry
2021-07-06 20:57             ` Andrew Berry
2021-07-06 21:57               ` Junio C Hamano
2021-07-07  0:18                 ` Junio C Hamano
2021-07-07  0:32                   ` Andrew Berry
2021-07-07  1:20                     ` Junio C Hamano
2021-07-18 14:12                 ` Andrew Berry
2021-07-19 18:36                   ` Junio C Hamano
2021-07-06 21:55             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FBABC9-2BDF-4879-AB5A-BAE4E8179D80@furrypaws.ca \
    --to=andrew@furrypaws.ca \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).