From: Thomas Rast <trast@inf.ethz.ch>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Bo Yang <struggleyb.nku@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH 00/11] blame/log -L: additional tests and bug fixes
Date: Sat, 3 Aug 2013 16:41:19 +0200 [thread overview]
Message-ID: <87ob9e25ww.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <1375258545-42240-1-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Wed, 31 Jul 2013 04:15:34 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> While working on multiple -L support for git-blame, I encountered more
> issues with the existing -L facility in git-blame and git-log. This
> series fixes these problems and adds a slew of new tests.
>
> Patch 6/11 (t4211: retire soon-to-be unimplementable tests) may be
> controversial. Removal of these tests was effectively a decision made in
> isolation since my request for input [1] regarding the issue generated
> only a single response (from j6t).
I agree with that decision. It's better to not leave any user-facing
quirks just for internal's sake.
The right thing would be to either expose enough of the range_set api
through a test-range-set command, or just write all the tests in C.
Both seem a bit excessive since the API doesn't have any users outside
of log -L, which probably approaches "reasonable quality" now that you
shaked it down quite a bit.
As for the series, my tuits don't go further than a cursory read today,
but from that it seems good.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2013-08-03 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:15 [PATCH 00/11] blame/log -L: additional tests and bug fixes Eric Sunshine
2013-07-31 8:15 ` [PATCH 01/11] t8001/t8002: blame: decompose overly-large test Eric Sunshine
2013-07-31 8:15 ` [PATCH 02/11] t8001/t8002: blame: demonstrate -L bounds checking bug Eric Sunshine
2013-08-05 19:29 ` Junio C Hamano
2013-08-05 19:35 ` Eric Sunshine
2013-08-05 19:45 ` Eric Sunshine
2013-08-05 23:30 ` Junio C Hamano
2013-07-31 8:15 ` [PATCH 03/11] t8001/t8002: blame: add empty file & partial-line tests Eric Sunshine
2013-07-31 8:15 ` [PATCH 04/11] blame: fix -L bounds checking bug Eric Sunshine
2013-07-31 8:15 ` [PATCH 05/11] t4211: log: demonstrate " Eric Sunshine
2013-07-31 8:15 ` [PATCH 06/11] t4211: retire soon-to-be unimplementable tests Eric Sunshine
2013-07-31 8:15 ` [PATCH 07/11] log: fix -L bounds checking bug Eric Sunshine
2013-07-31 8:15 ` [PATCH 08/11] t8001/t8002: blame: demonstrate acceptance of bogus -LX,+0 and -LX,-0 Eric Sunshine
2013-07-31 8:15 ` [PATCH 09/11] blame: reject empty ranges " Eric Sunshine
2013-07-31 8:15 ` [PATCH 10/11] t8001/t8002: blame: demonstrate acceptance of bogus -L,+0 and -L,-0 Eric Sunshine
2013-07-31 8:15 ` [PATCH 11/11] blame: reject empty ranges " Eric Sunshine
2013-08-03 14:41 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob9e25ww.fsf@hexa.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=struggleyb.nku@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).