From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] blame: accept multiple -L ranges
Date: Wed, 10 Jul 2013 11:18:26 +0200 [thread overview]
Message-ID: <87mwpuepst.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <7vppurv8bl.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 09 Jul 2013 12:31:42 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Thomas Rast <trast@inf.ethz.ch> writes:
>
>> If you define it that way, the output of
>>
>> git blame -L 4,6; git blame -L /A/,+20
>>
>> is significantly different from
>>
>> git blame -L 4,6 -L /A/,+20
>>
>> Not just in the presentation or any possible coalescing, but in the
>> meaning of the ranges.
>>
>> Do you really want to make it that way?
>
> Absolutely. The primary reason I want to be able to specify two
> ranges at the same time is to follow two functions in a file that
> appear in separate places, and /A/ might not be unique. When I want
> to say "I want to see from here to there, and then from here to
> there, and then from here to there", it would be very frustrating if
> "and then" resets what I mean by "here" every time and make these
> three evaluated independently.
Ok, fair enough. That is at least an argument other than "trust me, I
care deeply" :-)
But still, log -L should then be changed to match this behavior (for all
args affecting a single file). Currently it always does the scan for
the start of the range from line 1 of the file.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-07-10 9:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 8:45 [PATCH/RFC] blame: accept multiple -L ranges Eric Sunshine
2013-07-07 9:58 ` Junio C Hamano
2013-07-09 15:04 ` Eric Sunshine
2013-07-09 16:39 ` Junio C Hamano
2013-07-09 17:17 ` Eric Sunshine
2013-07-09 17:42 ` Thomas Rast
2013-07-09 18:23 ` Eric Sunshine
2013-07-09 18:55 ` Junio C Hamano
2013-07-09 19:07 ` Eric Sunshine
2013-07-09 19:12 ` Thomas Rast
2013-07-09 19:21 ` Jonathan Nieder
2013-07-09 19:31 ` Junio C Hamano
2013-07-09 19:57 ` Michael Haggerty
2013-07-09 20:25 ` Junio C Hamano
2013-07-22 8:12 ` Eric Sunshine
2013-07-22 10:39 ` Thomas Rast
2013-07-22 17:23 ` Junio C Hamano
2013-07-22 19:19 ` Thomas Rast
2013-07-22 21:34 ` Junio C Hamano
2013-07-10 9:18 ` Thomas Rast [this message]
2013-07-11 16:44 ` Junio C Hamano
2013-07-09 18:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwpuepst.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).