From: Eric Sunshine <sunshine@sunshineco.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] blame: accept multiple -L ranges
Date: Tue, 9 Jul 2013 14:23:55 -0400 [thread overview]
Message-ID: <CAPig+cT9U7L-03Fe5YLft=WS2EZY1B_BhLzkM_sT_3wQQ1g1MQ@mail.gmail.com> (raw)
In-Reply-To: <87ehb7d3za.fsf@hexa.v.cablecom.net>
On Tue, Jul 9, 2013 at 1:42 PM, Thomas Rast <trast@inf.ethz.ch> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> (2) In the ranges "-L <anything>,/B/ -L /C/,<anything>", the
>> beginning of the second range is found by choosing C that comes
>> _after_ the end of the previous range (/B/ may choose either
>> the second or the 4th line, and the only C that comes after
>> either of them is the 5th line and that is where the second
>> range should begin, not at the beginning of the file). The
>> same for "-L 1,3 -L /C/" (only C that comes after 3 is eligible
>> to be the beginning of the second range).
>
> So passing several -L arguments does not blame the union of what each
> argument would blame individually? Doesn't that make it rather harder
> to explain?
I don't think Junio meant to imply that. Collecting the blame ranges
can/should be a distinct step from coalescing them. Junio is saying
that an -L /re/ range search should start after the maximum line
number already specified by any preceding range. Once all input ranges
are collected, they can be coalesced. (If a -L /re/ range happens to
be coalesced with or into some other range, that's fine: you're still
seeing blame output for the requested lines.)
-- ES
next prev parent reply other threads:[~2013-07-09 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 8:45 [PATCH/RFC] blame: accept multiple -L ranges Eric Sunshine
2013-07-07 9:58 ` Junio C Hamano
2013-07-09 15:04 ` Eric Sunshine
2013-07-09 16:39 ` Junio C Hamano
2013-07-09 17:17 ` Eric Sunshine
2013-07-09 17:42 ` Thomas Rast
2013-07-09 18:23 ` Eric Sunshine [this message]
2013-07-09 18:55 ` Junio C Hamano
2013-07-09 19:07 ` Eric Sunshine
2013-07-09 19:12 ` Thomas Rast
2013-07-09 19:21 ` Jonathan Nieder
2013-07-09 19:31 ` Junio C Hamano
2013-07-09 19:57 ` Michael Haggerty
2013-07-09 20:25 ` Junio C Hamano
2013-07-22 8:12 ` Eric Sunshine
2013-07-22 10:39 ` Thomas Rast
2013-07-22 17:23 ` Junio C Hamano
2013-07-22 19:19 ` Thomas Rast
2013-07-22 21:34 ` Junio C Hamano
2013-07-10 9:18 ` Thomas Rast
2013-07-11 16:44 ` Junio C Hamano
2013-07-09 18:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cT9U7L-03Fe5YLft=WS2EZY1B_BhLzkM_sT_3wQQ1g1MQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).