From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: "Clément Poulain" <clement.poulain@ensimag.imag.fr>
Cc: Kirill Smelkov <kirr@landau.phys.spbu.ru>, git@vger.kernel.org
Subject: Re: [BUG] git gui blame fails for multi-word textconv filter
Date: Thu, 05 Aug 2010 23:58:42 +0100 [thread overview]
Message-ID: <87iq3osm3h.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <4C59FBD5.5090209@ensimag.imag.fr> ("Clément Poulain"'s message of "Thu, 05 Aug 2010 01:46:29 +0200")
Clément Poulain <clement.poulain@ensimag.imag.fr> writes:
>Le 04/08/2010 21:25, Kirill Smelkov a écrit :
>> Hello,
>>
>> I use
>>
>> [diff "astextplain"]
>> textconv = run-mailcap --action=cat
>>
>> in my ~/.gitconfig, and this works for git `git blame` because of 41a457
>> in git.git (textconv: use shell to run helper), but fails with git gui:
>>
>> $ git gui blame 21980.2--ИМС-МР231.doc
>> Error in startup script: couldn't execute "run-mailcap --action=cat": no such file or directory
>>
>I wonder if spaces can be the reason of this. Looks like Tcl is
>looking for an executable called "run-mailcap --action=cat", and
>doesn't distinguish path from options.
indeed. We passed a 2-element list and the first element is the
command. To permit this we need to append the pathname to the command
instead.
open |[linsert $path 0 $cmd_plus_args_list]
is a safe way to do that.
I should have thought of that too and not just repos with spaces in the path.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
prev parent reply other threads:[~2010-08-05 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 19:25 [BUG] git gui blame fails for multi-word textconv filter Kirill Smelkov
2010-08-04 23:46 ` Clément Poulain
2010-08-05 9:59 ` Matthieu Moy
2010-08-05 10:05 ` [PATCH] git-gui: Use shell to launch textconv filter in "blame" Matthieu Moy
2010-08-05 23:10 ` Pat Thoyts
2010-08-06 8:51 ` Matthieu Moy
2010-08-06 17:56 ` Pat Thoyts
2010-08-19 8:05 ` [BUG] git gui blame fails for multi-word textconv filter Kirill Smelkov
2010-08-05 22:58 ` Pat Thoyts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iq3osm3h.fsf@fox.patthoyts.tk \
--to=patthoyts@users.sourceforge.net \
--cc=clement.poulain@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=kirr@landau.phys.spbu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).