From: Kirill Smelkov <kirr@landau.phys.spbu.ru>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: Clment Poulain <clement.poulain@ensimag.imag.fr>, git@vger.kernel.org
Subject: [BUG] git gui blame fails for multi-word textconv filter
Date: Wed, 4 Aug 2010 23:25:25 +0400 [thread overview]
Message-ID: <20100804192525.GA13086@landau.phys.spbu.ru> (raw)
Hello,
I use
[diff "astextplain"]
textconv = run-mailcap --action=cat
in my ~/.gitconfig, and this works for git `git blame` because of 41a457
in git.git (textconv: use shell to run helper), but fails with git gui:
$ git gui blame 21980.2--ИМС-МР231.doc
Error in startup script: couldn't execute "run-mailcap --action=cat": no such file or directory
while executing
"open |[list $textconv $path] r"
(procedure "_load" line 56)
invoked from within
"_load $this $i_jump"
(procedure "blame::new" line 185)
invoked from within
"blame::new $head $path $jump_spec"
("blame" arm line 6)
invoked from within
"switch -- $subcommand {
browser {
if {$jump_spec ne {}} usage
if {$head eq {}} {
if {$path ne {} && [file isdirectory $path]} {
set head $..."
("blame" arm line 57)
invoked from within
"switch -- $subcommand {
browser -
blame {
if {$subcommand eq "blame"} {
set subcommand_args {[--line=<num>] rev? path}
} else {
set subcommand_a..."
(file "/home/kirr/local/git/libexec/git-core/git-gui" line 2868)
Thats is maybe because we use `git cat-file --textconv` only for in .git
entries, but since cat-file lacks support for work-tree git-gui calls
textconv filter itself manually on initial "$commit eq {}"?
If so, I'd better teach cat-file about worktree, instead of teaching
git-gui about running textconv filter through shell. Just a wish...
Thanks,
Kirill
P.S. And thanks for finally collecting all those git-gui patches.
next reply other threads:[~2010-08-04 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 19:25 Kirill Smelkov [this message]
2010-08-04 23:46 ` [BUG] git gui blame fails for multi-word textconv filter Clément Poulain
2010-08-05 9:59 ` Matthieu Moy
2010-08-05 10:05 ` [PATCH] git-gui: Use shell to launch textconv filter in "blame" Matthieu Moy
2010-08-05 23:10 ` Pat Thoyts
2010-08-06 8:51 ` Matthieu Moy
2010-08-06 17:56 ` Pat Thoyts
2010-08-19 8:05 ` [BUG] git gui blame fails for multi-word textconv filter Kirill Smelkov
2010-08-05 22:58 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804192525.GA13086@landau.phys.spbu.ru \
--to=kirr@landau.phys.spbu.ru \
--cc=clement.poulain@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).