From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Edward Thomson <ethomson@edwardthomson.com>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
demerphq <demerphq@gmail.com>,
Brandon Williams <bmwill@google.com>,
Derrick Stolee <stolee@gmail.com>
Subject: How is the ^{sha256} peel syntax supposed to work?
Date: Wed, 29 Aug 2018 11:13:25 +0200 [thread overview]
Message-ID: <877ek9edsa.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180824014703.GE99542@aiede.svl.corp.google.com>
On Fri, Aug 24 2018, Jonathan Nieder wrote:
> Hi,
>
> Ævar Arnfjörð Bjarmason wrote:
>
>>> git --output-format=sha1 log abac87a^{sha1}..f787cac^{sha256}
>>
>> How is this going to interact with other peel syntax? I.e. now we have
>> <object>^{commit} <sha>^{tag} etc. It seems to me we'll need not ^{sha1}
>> but ^{sha1:<current_type>}, e.g. ^{sha1:commit} or ^{sha1:tag}, with
>> current ^{} being a synonym for ^{sha1:}.
>>
>> Or is this expected to be chained, as e.g. <object>^{tag}^{sha256} ?
>
> Great question. The latter (well, <hexdigits>^{sha256}^{tag}, not the
> other way around).
Since nobody's chimed in with an answer, and I suspect many have an
adversion to that big thread I thought I'd spin out just this small
question into its own thread.
brian m. carlson did some prep work for this in his just-submitted
https://public-inbox.org/git/20180829005857.980820-2-sandals@crustytoothpaste.net/
I was going to work on some of the peel code soon (digging up the type
disambiguation patches I still need to re-submit), so could do this
while I'm at it, i.e. implement ^{sha1}.
But as noted above it's not clear how it should work. Jonathan's
chaining suggestion (<hexdigits>^{sha256}^{tag} not
<hexdigits>^{tag}^{sha256}) makes more sense than mine, but is that what
we're going for, or ^{sha256:tag}?
next prev parent reply other threads:[~2018-08-29 9:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 14:02 Questions about the hash function transition Ævar Arnfjörð Bjarmason
2018-08-23 14:27 ` Junio C Hamano
2018-08-23 15:20 ` Ævar Arnfjörð Bjarmason
2018-08-23 16:13 ` Junio C Hamano
2018-08-24 1:40 ` brian m. carlson
2018-08-24 1:54 ` Jonathan Nieder
2018-08-24 4:47 ` brian m. carlson
2018-08-24 4:52 ` Jonathan Nieder
2018-08-24 1:47 ` Jonathan Nieder
2018-08-28 12:04 ` Johannes Schindelin
2018-08-28 12:49 ` Derrick Stolee
2018-08-28 17:12 ` Jonathan Nieder
2018-08-28 17:11 ` Jonathan Nieder
2018-08-29 13:09 ` Johannes Schindelin
2018-08-29 13:27 ` Derrick Stolee
2018-08-29 14:43 ` Derrick Stolee
2018-08-29 9:13 ` Ævar Arnfjörð Bjarmason [this message]
2018-08-29 17:51 ` How is the ^{sha256} peel syntax supposed to work? Stefan Beller
2018-08-29 17:59 ` Jonathan Nieder
2018-08-29 18:34 ` Stefan Beller
2018-08-29 18:41 ` Ævar Arnfjörð Bjarmason
2018-08-29 19:12 ` Jonathan Nieder
2018-08-29 19:37 ` Ævar Arnfjörð Bjarmason
2018-08-29 20:46 ` Jonathan Nieder
2018-08-29 23:45 ` Jeff King
2018-08-29 20:53 ` Junio C Hamano
2018-08-29 21:01 ` Jonathan Nieder
2018-08-29 17:56 ` Jonathan Nieder
2018-08-24 2:51 ` Questions about the hash function transition Jonathan Nieder
2018-08-28 13:50 ` Ævar Arnfjörð Bjarmason
2018-08-28 14:15 ` Edward Thomson
2018-08-28 15:02 ` Ævar Arnfjörð Bjarmason
2018-08-28 15:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ek9edsa.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bmwill@google.com \
--cc=demerphq@gmail.com \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).