From: Derrick Stolee <stolee@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Edward Thomson" <ethomson@edwardthomson.com>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
demerphq <demerphq@gmail.com>,
"Brandon Williams" <bmwill@google.com>
Subject: Re: Questions about the hash function transition
Date: Wed, 29 Aug 2018 10:43:37 -0400 [thread overview]
Message-ID: <74787b14-ea63-de76-4eba-ce322aa7b1d2@gmail.com> (raw)
In-Reply-To: <04300dbc-622a-c8cb-172e-985726249a8e@gmail.com>
On 8/29/2018 9:27 AM, Derrick Stolee wrote:
> On 8/29/2018 9:09 AM, Johannes Schindelin wrote:
>>
>> What I meant was to leverage the midx code, not the .midx files.
>>
>> My comment was motivated by my realizing that both the SHA-1 <-> SHA-256
>> mapping and the MIDX code have to look up (in a *fast* way) information
>> with hash values as keys. *And* this information is immutable. *And* the
>> amount of information should grow with new objects being added to the
>> database.
>
> I'm unsure what this means, as the multi-pack-index simply uses
> bsearch_hash() to find hashes in the list. The same method is used for
> IDX lookups.
>
I talked with Johannes privately, and we found differences in our
understanding of the current multi-pack-index feature. Johannes thought
the feature was farther along than it is, specifically related to how
much we value the data in the multi-pack-index when adding objects to
pack-files or repacking. Some of this misunderstanding is due to how the
equivalent feature works in VSTS (where there is no IDX-file equivalent,
every object in the repo is tracked by a multi-pack-index).
I'd like to point out a few things about how the multi-pack-index works
now, and how we hope to extend it in the future.
Currently:
1. Objects are added to the multi-pack-index by adding a new set of
.idx/.pack file pairs. We scan the .idx file for the objects and offsets
to add.
2. We re-use the information in the multi-pack-index only to write the
new one without re-reading the .pack files that are already covered.
3. If a 'git repack' command deletes a pack-file, then we delete the
multi-pack-index. It must be regenerated by 'git multi-pack-index write'
later.
In the current world, the multi-pack-index is completely secondary to
the .idx files.
In the future, I hope these features exist in the multi-pack-index:
1. A stable object order. As objects are added to the multi-pack-index,
we assign a distinct integer value to each. As we add objects, those
integers values do not change. We can then pair the reachability bitmap
to the multi-pack-index instead of a specific pack-file (allowing repack
and bitmap computations to happen asynchronously). The data required to
store this object order is very similar to storing the bijection between
SHA-1 and SHA-256 hashes.
2. Incremental multi-pack-index: Currently, we have only one
multi-pack-index file per object directory. We can use a mechanism
similar to the split-index to keep a small number of multi-pack-index
files (at most 3, probably) such that the
'.git/objects/pack/multi-pack-index' file is small and easy to rewrite,
while it refers to larger '.git/objects/pack/*.midx' files that change
infrequently.
3. Multi-pack-index-aware repack: The repacker only knows about the
multi-pack-index enough to delete it. We could instead directly
manipulate the multi-pack-index during repack, and we could decide to do
more incremental repacks based on data stored in the multi-pack-index.
In conclusion: please keep the multi-pack-index in mind as we implement
the transition plan. I'll continue building the feature as planned (the
next thing to do after the current series of cleanups is 'git
multi-pack-index verify') but am happy to look into other applications
as we need it.
Thanks,
-Stolee
next prev parent reply other threads:[~2018-08-29 14:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 14:02 Questions about the hash function transition Ævar Arnfjörð Bjarmason
2018-08-23 14:27 ` Junio C Hamano
2018-08-23 15:20 ` Ævar Arnfjörð Bjarmason
2018-08-23 16:13 ` Junio C Hamano
2018-08-24 1:40 ` brian m. carlson
2018-08-24 1:54 ` Jonathan Nieder
2018-08-24 4:47 ` brian m. carlson
2018-08-24 4:52 ` Jonathan Nieder
2018-08-24 1:47 ` Jonathan Nieder
2018-08-28 12:04 ` Johannes Schindelin
2018-08-28 12:49 ` Derrick Stolee
2018-08-28 17:12 ` Jonathan Nieder
2018-08-28 17:11 ` Jonathan Nieder
2018-08-29 13:09 ` Johannes Schindelin
2018-08-29 13:27 ` Derrick Stolee
2018-08-29 14:43 ` Derrick Stolee [this message]
2018-08-29 9:13 ` How is the ^{sha256} peel syntax supposed to work? Ævar Arnfjörð Bjarmason
2018-08-29 17:51 ` Stefan Beller
2018-08-29 17:59 ` Jonathan Nieder
2018-08-29 18:34 ` Stefan Beller
2018-08-29 18:41 ` Ævar Arnfjörð Bjarmason
2018-08-29 19:12 ` Jonathan Nieder
2018-08-29 19:37 ` Ævar Arnfjörð Bjarmason
2018-08-29 20:46 ` Jonathan Nieder
2018-08-29 23:45 ` Jeff King
2018-08-29 20:53 ` Junio C Hamano
2018-08-29 21:01 ` Jonathan Nieder
2018-08-29 17:56 ` Jonathan Nieder
2018-08-24 2:51 ` Questions about the hash function transition Jonathan Nieder
2018-08-28 13:50 ` Ævar Arnfjörð Bjarmason
2018-08-28 14:15 ` Edward Thomson
2018-08-28 15:02 ` Ævar Arnfjörð Bjarmason
2018-08-28 15:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74787b14-ea63-de76-4eba-ce322aa7b1d2@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=demerphq@gmail.com \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).