From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v8] help: add option to colorize man pages under less
Date: Sat, 26 Jun 2021 16:49:46 +0200 [thread overview]
Message-ID: <877digy8xe.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20210626025040.104428-1-felipe.contreras@gmail.com>
On Fri, Jun 25 2021, Felipe Contreras wrote:
> This a reroll of Ævar's v7 with comments from Jeff King so that
> color.ui=never doesn't disable color.man, and the documentation was
> updated accordingly.
>
> Additinally I removed one call to colorize_man() in exec_man_cmd() which
> is not meant for the man command (although it could be used for that).
>
> Plus a bunch of style changes to the commit message.
This version looks good to me, thanks for the style & grammar fixes on
my commit message additions.
> 1. color.man=true must be set in the config
> 2. The user must use less
> 3. Not have the same LESS_TERMCAP variables set (we call setenv(3) with overwrite=0)
> - 4. Have color.ui enabled
> - 5. Not have color.pager disabled
> - 6. Not have git with stdout directed to a file
> + 4. Not have color.pager disabled
> + 5. Not have git with stdout directed to a file
Even better.
> static struct cmdnames main_cmds, other_cmds;
> diff --git a/color.h b/color.h
> index 98894d6a17..d012add4e8 100644
> --- a/color.h
> +++ b/color.h
> @@ -51,6 +51,7 @@ struct strbuf;
> #define GIT_COLOR_FAINT "\033[2m"
> #define GIT_COLOR_FAINT_ITALIC "\033[2;3m"
> #define GIT_COLOR_REVERSE "\033[7m"
> +#define GIT_COLOR_UNDERLINE "\033[4m"
>
> /* A special value meaning "no color selected" */
> #define GIT_COLOR_NIL "NIL"
Not really needing, but I note that this adds something that we don't
have in test_decode_color(), not that we're testing this output
directly, so it doesn't matter for now.
prev parent reply other threads:[~2021-06-26 14:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 5:44 [PATCH v6] help: colorize man pages Felipe Contreras
2021-05-24 13:13 ` Phillip Wood
2021-05-24 16:56 ` Felipe Contreras
2021-06-08 12:35 ` Ævar Arnfjörð Bjarmason
2021-06-08 13:57 ` Junio C Hamano
2021-06-08 17:48 ` Felipe Contreras
2021-06-21 8:34 ` [PATCH v7] help: colorize man pages if man.color=true under less(1) Ævar Arnfjörð Bjarmason
2021-06-21 10:17 ` Phillip Wood
2021-06-21 10:28 ` Junio C Hamano
2021-06-21 18:41 ` Felipe Contreras
2021-06-21 19:08 ` Ævar Arnfjörð Bjarmason
2021-06-23 23:58 ` Jeff King
2021-06-24 1:03 ` Felipe Contreras
2021-06-28 17:37 ` Junio C Hamano
2021-06-28 18:05 ` Felipe Contreras
2021-06-21 15:59 ` Felipe Contreras
2021-06-24 0:08 ` Jeff King
2021-06-29 1:42 ` Junio C Hamano
2021-06-29 1:48 ` Felipe Contreras
2021-06-24 1:44 ` [PATCH v6] help: colorize man pages Felipe Contreras
2021-06-26 2:50 ` [PATCH v8] help: add option to colorize man pages under less Felipe Contreras
2021-06-26 14:49 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877digy8xe.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).