From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Jeff King <peff@peff.net>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v7] help: colorize man pages if man.color=true under less(1)
Date: Mon, 21 Jun 2021 13:41:37 -0500 [thread overview]
Message-ID: <60d0dd619a2c6_10782120814@natae.notmuch> (raw)
In-Reply-To: <xmqqfsxbika3.fsf@gitster.g>
Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> > Fair enough, here's a version I think you and others will find
> > acceptable then. It allows users like me who like this to explicitly
> > opt-in via color.man=true.
>
> Not really.
>
> Since the implementation of the posted patch, as I understand it,
> does not aim to affect both "git help -m foo" and "man git-foo"
> identically,
It cannot aim to do what is not possible.
> I think it would be easier to understand to end-users
> if this were exposed as a new "mode", like "git help --web" and "git
> help --info" are different modes from the "git help --man",
> something like "git help --fancy-man" (or whatever is easy to type
> and explain, and also add it to the variants help.format knows about
> to make it easy to set the default).
But it is not a new mode.
I presume you mean format, since man, info, and web are formats,
controlled by help.format.
But no, it's not a format either, because we still want to see the same
format (man).
Perhaps you meant a man viewer (controlled with man.viewer), but there's
no command line option to launch help with for example emacs woman.
But still, it's not a new viewer; it's an improvement of an already
existing viewer.
> One advantage of doing so is that we do not have to worry about "ah,
> user has LESS_BLAH environment variable so we should disable this
> new mode here" etc.
We don't have to worry about that with the current patch.
> As long as the new mode is requested either via
> the command line option or help.format configuration, it can
> completely take it over.
That is already the case.
> That simplifies the necessary explanation given to the users quite a
> lot, no?
No, it would still be:
1. man.viewer=fancyman must be set in the config
2. The user must use less
3. Not have the same LESS_TERMCAP variables set (we call setenv(3) with overwrite=0)
4. Have color.ui enabled
5. Not have color.pager disabled
6. Not have git with stdout directed to a file
Moreover, this explanation is for developers.
Realistically all the user needs to know is that color.man=true turns
this on (man.viewer=fancyman is not better in any way).
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-21 18:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 5:44 [PATCH v6] help: colorize man pages Felipe Contreras
2021-05-24 13:13 ` Phillip Wood
2021-05-24 16:56 ` Felipe Contreras
2021-06-08 12:35 ` Ævar Arnfjörð Bjarmason
2021-06-08 13:57 ` Junio C Hamano
2021-06-08 17:48 ` Felipe Contreras
2021-06-21 8:34 ` [PATCH v7] help: colorize man pages if man.color=true under less(1) Ævar Arnfjörð Bjarmason
2021-06-21 10:17 ` Phillip Wood
2021-06-21 10:28 ` Junio C Hamano
2021-06-21 18:41 ` Felipe Contreras [this message]
2021-06-21 19:08 ` Ævar Arnfjörð Bjarmason
2021-06-23 23:58 ` Jeff King
2021-06-24 1:03 ` Felipe Contreras
2021-06-28 17:37 ` Junio C Hamano
2021-06-28 18:05 ` Felipe Contreras
2021-06-21 15:59 ` Felipe Contreras
2021-06-24 0:08 ` Jeff King
2021-06-29 1:42 ` Junio C Hamano
2021-06-29 1:48 ` Felipe Contreras
2021-06-24 1:44 ` [PATCH v6] help: colorize man pages Felipe Contreras
2021-06-26 2:50 ` [PATCH v8] help: add option to colorize man pages under less Felipe Contreras
2021-06-26 14:49 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60d0dd619a2c6_10782120814@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).