From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Sun Chao via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Sun Chao <16657101987@163.com>
Subject: Re: [PATCH] packfile: enhance the mtime of packfile by idx file
Date: Mon, 12 Jul 2021 01:44:15 +0200 [thread overview]
Message-ID: <874kd04dgo.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <pull.1043.git.git.1625943685565.gitgitgadget@gmail.com>
On Sat, Jul 10 2021, Sun Chao via GitGitGadget wrote:
> From: Sun Chao <16657101987@163.com>
>
> Commit 33d4221c79 (write_sha1_file: freshen existing objects,
> 2014-10-15) avoid writing existing objects by freshen their
> mtime (especially the packfiles contains them) in order to
> aid the correct caching, and some process like find_lru_pack
> can make good decision. However, this is unfriendly to
> incremental backup jobs or services rely on file system
> cache when there are large '.pack' files exists.
>
> For example, after packed all objects, use 'write-tree' to
> create same commit with the same tree and same environments
> such like GIT_COMMITTER_DATE and GIT_AUTHOR_DATE, we can
> notice the '.pack' file's mtime changed, but '.idx' file not.
>
> So if we update the mtime of packfile by updating the '.idx'
> file instead of '.pack' file, when we check the mtime
> of packfile, get it from '.idx' file instead. Large git
> repository may contains large '.pack' files, but '.idx'
> files are smaller enough, this can avoid file system cache
> reload the large files again and speed up git commands.
>
> Signed-off-by: Sun Chao <16657101987@163.com>
Does this have the unstated trade-off that in a mixed-version
environment (say two git versions coordinating writes to an NFS share)
where one is old and thinks *.pack needs updating, and the other is new
and thinks *.idx is what should be checked, that until both are upgraded
we're effectively back to pre-33d4221c79.
I don't think it's a dealbreaker, just wondering if I've got that right
& if it is's a trade-off you thought about, maybe we should check the
mtime of both. The stat() is cheap, it's the re-sync that matters for
you.
But just to run with that thought, wouldn't it be even more helpful to
you to have say a config setting to create a *.bump file next to the
*.{idx,pack}.
Then you'd have an empty file (the *.idx is smaller, but still not
empty), and as a patch it seems relatively simple, i.e. some core.* or
gc.* or pack.* setting changing what we touch/stat().
next prev parent reply other threads:[~2021-07-11 23:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 19:01 [PATCH] packfile: enhance the mtime of packfile by idx file Sun Chao via GitGitGadget
2021-07-11 23:44 ` Ævar Arnfjörð Bjarmason [this message]
2021-07-12 16:17 ` Sun Chao
2021-07-14 1:28 ` [PATCH v2] packfile: freshen the mtime of packfile by configuration Sun Chao via GitGitGadget
2021-07-14 1:39 ` Ævar Arnfjörð Bjarmason
2021-07-14 2:52 ` Taylor Blau
2021-07-14 16:46 ` Sun Chao
2021-07-14 17:04 ` Taylor Blau
2021-07-14 18:19 ` Ævar Arnfjörð Bjarmason
2021-07-14 19:11 ` Martin Fick
2021-07-14 19:41 ` Ævar Arnfjörð Bjarmason
2021-07-14 20:20 ` Martin Fick
2021-07-20 6:32 ` Ævar Arnfjörð Bjarmason
2021-07-15 8:23 ` Son Luong Ngoc
2021-07-20 6:29 ` Ævar Arnfjörð Bjarmason
2021-07-14 19:30 ` Taylor Blau
2021-07-14 19:32 ` Ævar Arnfjörð Bjarmason
2021-07-14 19:52 ` Taylor Blau
2021-07-14 21:40 ` Junio C Hamano
2021-07-15 16:30 ` Sun Chao
2021-07-15 16:42 ` Taylor Blau
2021-07-15 16:48 ` Sun Chao
2021-07-14 16:11 ` Sun Chao
2021-07-19 19:53 ` [PATCH v3] " Sun Chao via GitGitGadget
2021-07-19 20:51 ` Taylor Blau
2021-07-20 0:07 ` Junio C Hamano
2021-07-20 15:07 ` Sun Chao
2021-07-20 6:19 ` Ævar Arnfjörð Bjarmason
2021-07-20 15:34 ` Sun Chao
2021-07-20 15:00 ` Sun Chao
2021-07-20 16:53 ` Taylor Blau
2021-08-15 17:08 ` [PATCH v4 0/2] " Sun Chao via GitGitGadget
2021-08-15 17:08 ` [PATCH v4 1/2] packfile: rename `derive_filename()` to `derive_pack_filename()` Sun Chao via GitGitGadget
2021-08-15 17:08 ` [PATCH v4 2/2] packfile: freshen the mtime of packfile by bump file Sun Chao via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kd04dgo.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=16657101987@163.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).