* [GSoC] Microproject: Add more builtin patterns for userdiff
@ 2019-03-15 9:09 Kapil Jain
2019-03-15 12:56 ` Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 2+ messages in thread
From: Kapil Jain @ 2019-03-15 9:09 UTC (permalink / raw)
To: git, Thomas Gummerer
Hi,
for the microproject: creating diff function support for different languages.
i wrote one for shell script, have tested it outside of git and it works fine.
query regarding accommodating the pattern in:
1) userdiff.c, it uses - #define PATTERNS(name, pattern, word_regex),
for defining patterns to locate functions.
what is the use of pattern and word_regex parameters ? i am guessing
that pattern parameter is the actual pattern to spot functions in a
file,
and word_regex is used to get function name. is that correct ?
please let me know.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [GSoC] Microproject: Add more builtin patterns for userdiff
2019-03-15 9:09 [GSoC] Microproject: Add more builtin patterns for userdiff Kapil Jain
@ 2019-03-15 12:56 ` Ævar Arnfjörð Bjarmason
0 siblings, 0 replies; 2+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2019-03-15 12:56 UTC (permalink / raw)
To: Kapil Jain; +Cc: git, Thomas Gummerer
On Fri, Mar 15 2019, Kapil Jain wrote:
> Hi,
>
> for the microproject: creating diff function support for different languages.
> i wrote one for shell script, have tested it outside of git and it works fine.
>
> query regarding accommodating the pattern in:
> 1) userdiff.c, it uses - #define PATTERNS(name, pattern, word_regex),
> for defining patterns to locate functions.
> what is the use of pattern and word_regex parameters ? i am guessing
> that pattern parameter is the actual pattern to spot functions in a
> file,
Yes, except "functions". More like "logical start of
stuff". E.g. "package" statements for Perl etc.
So whatever makes the most sense to put in the "@" context line for diff
to give the user an idea of what "function" this is changing, in the
loosest possible sense of "function".
> and word_regex is used to get function name. is that correct ?
> please let me know.
No, it's whatever counts as a "token" in the language for the purpose of
"diff --word-diff". So it needs to match e.g. operators as one unit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-15 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 9:09 [GSoC] Microproject: Add more builtin patterns for userdiff Kapil Jain
2019-03-15 12:56 ` Ævar Arnfjörð Bjarmason
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).