git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Thomas Rast <tr@thomasrast.ch>
To: Jeff King <peff@peff.net>
Cc: Murtuza Mukadam <murtuza.i.mukadam@gmail.com>,
	git@vger.kernel.org, Peter Rigby <peter.rigby@concordia.ca>
Subject: Re: Fwd: git-reviewed: linking commits to review discussion in git
Date: Sat, 22 Feb 2014 17:47:54 +0100	[thread overview]
Message-ID: <871tyvrt51.fsf@thomasrast.ch> (raw)
In-Reply-To: <20140218052827.GA25291@sigill.intra.peff.net> (Jeff King's message of "Tue, 18 Feb 2014 00:28:27 -0500")

Jeff King <peff@peff.net> writes:

> On Mon, Feb 17, 2014 at 03:12:48PM -0500, Murtuza Mukadam wrote:
>
>> We have linked peer review discussions on
>> git@vger.kernel.org to their respective commits within the main
>> git.git repository. You can view the linked reviews from 2012
>> until present in the GitHub repo at:
>> https://github.com/mmukadam/git/tree/review
>
> Neat. We've experimented in the past with mapping commits back to
> mailing list discussions.  Thomas (cc'd) has a script that creates
> git-notes trees mapping commits to the relevant message-id, which can
> then be found in the list archive.
>
> To me, the interesting bits of such a project are:
>
>   1. How do we decide which messages led to which commits? There is
>      definitely some room for heuristics here, as patches are sometimes
>      tweaked in transit, or come in multiple stages (e.g., the original
>      patch, then somebody suggests a fixup on top). You might want to
>      compare your work with the script from Thomas here:
>
>        http://repo.or.cz/w/trackgit.git

Eh, or don't.  My script nowadays uses Junio's suggestion of matching on
(author, authordate) with a little bit of tweaking in case there is no
match.  The name/date match works for most cases even in slightly
tweaked forms.

(The very first version elaborately tried all sorts of things, including
attempting to patch on master, next etc. to see where it applies, and
turned out to be waaaay too slow.)

I'm no longer convinced that there's anything a computer can do beyond
(author, authordate), anyway.  Perhaps someone with a clue in UIs --
that's definitely not me -- could make a website where users can
complete or correct the autogenerated mappings to go further.

-- 
Thomas Rast
tr@thomasrast.ch

  reply	other threads:[~2014-02-22 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CANx4bCB5tTzKusbfcqQ=eoeOGJ-WxWvF3QNpfa5rTq7oOSG-5w@mail.gmail.com>
2014-02-17 20:12 ` Fwd: git-reviewed: linking commits to review discussion in git Murtuza Mukadam
2014-02-18  5:28   ` Jeff King
2014-02-22 16:47     ` Thomas Rast [this message]
     [not found]     ` <8635c4b807ab40db93da43875645dfc8@UMS-SGWHTS1.concordia.ca>
2014-03-10 23:43       ` Peter C Rigby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tyvrt51.fsf@thomasrast.ch \
    --to=tr@thomasrast.ch \
    --cc=git@vger.kernel.org \
    --cc=murtuza.i.mukadam@gmail.com \
    --cc=peff@peff.net \
    --cc=peter.rigby@concordia.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).