From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Rast Subject: Re: Fwd: git-reviewed: linking commits to review discussion in git Date: Sat, 22 Feb 2014 17:47:54 +0100 Message-ID: <871tyvrt51.fsf@thomasrast.ch> References: <20140218052827.GA25291@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain Cc: Murtuza Mukadam , git@vger.kernel.org, Peter Rigby To: Jeff King X-From: git-owner@vger.kernel.org Sat Feb 22 17:48:23 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WHFkU-0001mn-MU for gcvg-git-2@plane.gmane.org; Sat, 22 Feb 2014 17:48:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbaBVQsN (ORCPT ); Sat, 22 Feb 2014 11:48:13 -0500 Received: from ip1.thgersdorf.net ([148.251.9.194]:35517 "EHLO mail.psioc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbaBVQsH (ORCPT ); Sat, 22 Feb 2014 11:48:07 -0500 Received: from localhost (localhost [127.0.0.1]) by localhost.psioc.net (Postfix) with ESMTP id 6476F4D6590; Sat, 22 Feb 2014 17:48:05 +0100 (CET) X-Virus-Scanned: amavisd-new at psioc.net Received: from mail.psioc.net ([127.0.0.1]) by localhost (mail.psioc.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id D43u5haTk-yP; Sat, 22 Feb 2014 17:47:55 +0100 (CET) Received: from linux-1gf2.thomasrast.ch (46-126-8-85.dynamic.hispeed.ch [46.126.8.85]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.psioc.net (Postfix) with ESMTPSA id F142D4D64BD; Sat, 22 Feb 2014 17:47:54 +0100 (CET) In-Reply-To: <20140218052827.GA25291@sigill.intra.peff.net> (Jeff King's message of "Tue, 18 Feb 2014 00:28:27 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Jeff King writes: > On Mon, Feb 17, 2014 at 03:12:48PM -0500, Murtuza Mukadam wrote: > >> We have linked peer review discussions on >> git@vger.kernel.org to their respective commits within the main >> git.git repository. You can view the linked reviews from 2012 >> until present in the GitHub repo at: >> https://github.com/mmukadam/git/tree/review > > Neat. We've experimented in the past with mapping commits back to > mailing list discussions. Thomas (cc'd) has a script that creates > git-notes trees mapping commits to the relevant message-id, which can > then be found in the list archive. > > To me, the interesting bits of such a project are: > > 1. How do we decide which messages led to which commits? There is > definitely some room for heuristics here, as patches are sometimes > tweaked in transit, or come in multiple stages (e.g., the original > patch, then somebody suggests a fixup on top). You might want to > compare your work with the script from Thomas here: > > http://repo.or.cz/w/trackgit.git Eh, or don't. My script nowadays uses Junio's suggestion of matching on (author, authordate) with a little bit of tweaking in case there is no match. The name/date match works for most cases even in slightly tweaked forms. (The very first version elaborately tried all sorts of things, including attempting to patch on master, next etc. to see where it applies, and turned out to be waaaay too slow.) I'm no longer convinced that there's anything a computer can do beyond (author, authordate), anyway. Perhaps someone with a clue in UIs -- that's definitely not me -- could make a website where users can complete or correct the autogenerated mappings to go further. -- Thomas Rast tr@thomasrast.ch