* [PATCH] unexpected Make output (e.g. from --debug) causes build failure
@ 2007-09-25 6:42 Jim Meyering
2007-09-25 7:59 ` David Kastrup
0 siblings, 1 reply; 2+ messages in thread
From: Jim Meyering @ 2007-09-25 6:42 UTC (permalink / raw)
To: git
Without this, the extra output produced e.g., by "make --debug"
would go into $INSTLIBDIR and then cause the sed command to fail.
Signed-off-by: Jim Meyering <jim@meyering.net>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 0055eef..97ce687 100644
--- a/Makefile
+++ b/Makefile
@@ -805,7 +805,7 @@ perl/perl.mak: GIT-CFLAGS
$(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
$(QUIET_GEN)$(RM) $@ $@+ && \
- INSTLIBDIR=`$(MAKE) -C perl -s --no-print-directory instlibdir` && \
+ INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` && \
sed -e '1{' \
-e ' s|#!.*perl|#!$(PERL_PATH_SQ)|' \
-e ' h' \
--
1.5.3.2.99.ge4b2-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] unexpected Make output (e.g. from --debug) causes build failure
2007-09-25 6:42 [PATCH] unexpected Make output (e.g. from --debug) causes build failure Jim Meyering
@ 2007-09-25 7:59 ` David Kastrup
0 siblings, 0 replies; 2+ messages in thread
From: David Kastrup @ 2007-09-25 7:59 UTC (permalink / raw)
To: git
Jim Meyering <jim@meyering.net> writes:
> Without this, the extra output produced e.g., by "make --debug"
> would go into $INSTLIBDIR and then cause the sed command to fail.
>
> Signed-off-by: Jim Meyering <jim@meyering.net>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 0055eef..97ce687 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -805,7 +805,7 @@ perl/perl.mak: GIT-CFLAGS
>
> $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
> $(QUIET_GEN)$(RM) $@ $@+ && \
> - INSTLIBDIR=`$(MAKE) -C perl -s --no-print-directory instlibdir` && \
> + INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` && \
> sed -e '1{' \
> -e ' s|#!.*perl|#!$(PERL_PATH_SQ)|' \
> -e ' h' \
> --
> 1.5.3.2.99.ge4b2-dirty
Does this work with "make -n" ?
--
David Kastrup
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-25 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-25 6:42 [PATCH] unexpected Make output (e.g. from --debug) causes build failure Jim Meyering
2007-09-25 7:59 ` David Kastrup
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).