From: Jeff Hostetler <git@jeffhostetler.com>
To: "Derrick Stolee" <stolee@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Derrick Stolee <dstolee@microsoft.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2*
Date: Wed, 29 May 2019 15:52:41 -0400 [thread overview]
Message-ID: <8077e893-ebaf-9a23-2bf0-ba0ab78e7bae@jeffhostetler.com> (raw)
In-Reply-To: <f03e2ba6-36d8-d82b-3349-61341365b94e@gmail.com>
On 5/28/2019 12:46 PM, Derrick Stolee wrote:
> On 5/28/2019 12:25 PM, Junio C Hamano wrote:
>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>>
>>> For an environment variable that is supposed to be set by users, the
>>> GIT_TR2* env vars are just too unclear, inconsistent, and ugly.
>>
>> FWIW, I personally am in favor of this change and would prefer to see
>> this done before the use of the names with unguessable abbreviation
>> gets ingrained too deeply.
>>
>> I do not see any objections around these two patches after waiting
>> for a week or so, but I do not see any Yay!s, either, so ...
>
> Talking with Jeff offline, we have no objections to the new names.
>
> We'll need to do some follow-up work on our side as we update our
> version of Git, but that's not an issue.
>
> Thanks,
> -Stolee
>
Just to close the loop. Yes, I'm OK with changing the names.
Jeff
next prev parent reply other threads:[~2019-05-29 19:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:44 [PATCH 0/1] trace2: Add variable description to git.txt Derrick Stolee via GitGitGadget
2019-05-10 19:44 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-05-10 21:15 ` SZEDER Gábor
2019-05-19 14:43 ` [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2* SZEDER Gábor
2019-05-19 14:43 ` [PATCH 2/2] trace2: document the supported values of GIT_TRACE2* env variables SZEDER Gábor
2019-05-28 16:25 ` [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2* Junio C Hamano
2019-05-28 16:46 ` Derrick Stolee
2019-05-29 19:52 ` Jeff Hostetler [this message]
2019-05-28 23:02 ` Ævar Arnfjörð Bjarmason
2019-05-29 19:58 ` Jeff Hostetler
2019-05-29 21:45 ` Junio C Hamano
2019-06-12 14:29 ` [PATCH] Revert "test-lib: whitelist GIT_TR2_* in the environment" Ævar Arnfjörð Bjarmason
2019-06-12 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8077e893-ebaf-9a23-2bf0-ba0ab78e7bae@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).