From: Junio C Hamano <firstname.lastname@example.org>
To: Jeff Hostetler <email@example.com>
Cc: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org>,
"SZEDER Gábor" <email@example.com>,
"Derrick Stolee" <firstname.lastname@example.org>,
Subject: Re: [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2*
Date: Wed, 29 May 2019 14:45:30 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Jeff Hostetler's message of "Wed, 29 May 2019 15:58:32 -0400")
Jeff Hostetler <email@example.com> writes:
> On 5/28/2019 7:02 PM, Ævar Arnfjörð Bjarmason wrote:
>> On Sun, May 19 2019, SZEDER Gábor wrote:
>>> So let's rename all GIT_TR2* environment variables to GIT_TRACE2*,
>>> before they make their way into a stable release.
>> Good to see this land in 2.22.0. I wonder if we shouldn't take this
>> further and rename trace2.* config to trace.*, and just re-use
>> GIT_TRACE=1 instead of having GIT_TRACE2 as well, and have a
>> GIT_TRACE_VERSION to switch between them.
>> Then we could just switch in a future version. We've never promised what
>> the trace format was going to look like, and the existing one isn't
>> configurable (and we won't be making the v1 one...), so starting from
>> the outset with "2" in config is unfortunate.
>> We'd still have special snowflakes like e.g. GIT_TRACE_PACKET.
>> OTOH we can just do this after the release if it's deemed a good idea,
>> and just support trace2.* as aliases for trace.* for some amount of
>> time, same for the env vars.
> I'm open to considering such a change while we're at it.
I'm a bit against "while we're at it" part. Let's take the
s/TR2/TRACE2/ change and stop at it for the upcoming release,
without spending too much time on over-engineering the stuff that
are primarily for developers.
next prev parent reply other threads:[~2019-05-29 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:44 [PATCH 0/1] trace2: Add variable description to git.txt Derrick Stolee via GitGitGadget
2019-05-10 19:44 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-05-10 21:15 ` SZEDER Gábor
2019-05-19 14:43 ` [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2* SZEDER Gábor
2019-05-19 14:43 ` [PATCH 2/2] trace2: document the supported values of GIT_TRACE2* env variables SZEDER Gábor
2019-05-28 16:25 ` [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2* Junio C Hamano
2019-05-28 16:46 ` Derrick Stolee
2019-05-29 19:52 ` Jeff Hostetler
2019-05-28 23:02 ` Ævar Arnfjörð Bjarmason
2019-05-29 19:58 ` Jeff Hostetler
2019-05-29 21:45 ` Junio C Hamano [this message]
2019-06-12 14:29 ` [PATCH] Revert "test-lib: whitelist GIT_TR2_* in the environment" Ævar Arnfjörð Bjarmason
2019-06-12 17:49 ` Junio C Hamano
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).