git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: Adam Szkoda via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Adam Szkoda <adaszko@gmail.com>
Subject: Re: [PATCH] ssh signing: better error message when key not in agent
Date: Wed, 18 Jan 2023 14:34:50 +0000	[thread overview]
Message-ID: <8025d5c7-ab55-c533-1997-05b4c7339d61@dunelm.org.uk> (raw)
In-Reply-To: <abec912c-065d-2098-962e-41f9646dd046@dunelm.org.uk>

On 18/01/2023 11:10, Phillip Wood wrote:
>> the agent [1].  A fix is scheduled to be released in OpenSSH 9.1. All 
>> that
>> needs to be done is to pass an additional backward-compatible option 
>> -U to
>> 'ssh-keygen -Y sign' call.  With '-U', ssh-keygen always interprets 
>> the file
>> as public key and expects to find the private key in the agent.
> 
> The documentation for user.signingKey says
> 
>   If gpg.format is set to ssh this can contain the path to either your 
> private ssh key or the public key when ssh-agent is used.
> 
> If I've understood correctly passing -U will prevent users from setting 
> this to a private key.

If there is an easy way to tell if the user has given us a public key 
then we could pass "-U" in that case.

Best Wishes

Phillip

  reply	other threads:[~2023-01-18 14:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  8:17 [PATCH] ssh signing: better error message when key not in agent Adam Szkoda via GitGitGadget
2023-01-18 11:10 ` Phillip Wood
2023-01-18 14:34   ` Phillip Wood [this message]
2023-01-18 15:28     ` Adam Szkoda
2023-01-18 16:29       ` Phillip Wood
2023-01-20  9:03         ` Fabian Stelzer
2023-01-23  9:33           ` Phillip Wood
2023-01-23 10:02             ` Fabian Stelzer
2023-01-23 16:17               ` Adam Szkoda
2023-01-24 15:26 ` [PATCH v2] " Adam Szkoda via GitGitGadget
2023-01-24 17:52   ` Junio C Hamano
2023-01-25 12:46     ` Adam Szkoda
2023-01-25 17:04       ` Junio C Hamano
2023-01-25 17:17       ` Junio C Hamano
2023-01-25 21:42       ` Eric Sunshine
2023-01-25 22:22         ` Junio C Hamano
2023-02-15  1:22           ` Eric Sunshine
2023-01-25 12:40   ` [PATCH v3] " Adam Szkoda via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8025d5c7-ab55-c533-1997-05b4c7339d61@dunelm.org.uk \
    --to=phillip.wood123@gmail.com \
    --cc=adaszko@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).