list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Eric Sunshine <>
Cc: Adam Szkoda <>,
	Adam Szkoda via GitGitGadget <>,, Phillip Wood <>,
	Fabian Stelzer <>
Subject: Re: [PATCH v2] ssh signing: better error message when key not in agent
Date: Wed, 25 Jan 2023 14:22:59 -0800	[thread overview]
Message-ID: <xmqqedridzjw.fsf@gitster.g> (raw)
In-Reply-To: <> (Eric Sunshine's message of "Wed, 25 Jan 2023 16:42:26 -0500")

Eric Sunshine <> writes:

> On Wed, Jan 25, 2023 at 8:05 AM Adam Szkoda <> wrote:
>> On Tue, Jan 24, 2023 at 6:52 PM Junio C Hamano <> wrote:
>> > > Range-diff vs v1:
>> > >
>> > >  1:  0ce06076242 < -:  ----------- ssh signing: better error message when key not in agent
>> > >  -:  ----------- > 1:  03dfca79387 ssh signing: better error message when key not in agent
>> >
>> > This is a fairly useless range-diff.
>> >
>> > Even when a range-diff shows the differences in the patches,
>> > mechanically generated range-diff can only show _what_ changed.  It
>> > is helpful to explain the changes in your own words to highlight
>> > _why_ such changes are done, and this place after the "---" line
>> > and the diffstat we see below is the place to do so.
>> >
>> > Does GitGitGadget allow its users to describe the differences since
>> > the previous iteration yourself?
>> No, I don't think it does.   It got generated automatically without
>> giving me an opportunity to edit.
> Yes, the user can describe the differences since the previous
> iteration by editing the pull-request's description. Specifically,
> when ready to send a new iteration:
> (1) force push the new iteration to the same branch on GitHub
> (2) edit the pull-request description; this is the very first
> "comment" on the pull-request page; press the "..." button on that
> comment and choose the "Edit" menu item; revise the text to describe
> the changes since the previous revision, then press the "Update
> comment" button to save
> (3) post a "/submit" comment to the pull-request to tell GitGitGadget
> to send the new revision to the Git mailing list

Thanks.  I thought the above would make a good addition to our
documentation set.  Documentation/MyFirstContribution.txt does have
this to say:

    Once you have your branch again in the shape you want following all review
    comments, you can submit again:

    $ git push -f remotename psuh

    Next, go look at your pull request against GitGitGadget; you should see the CI
    has been kicked off again. Now while the CI is running is a good time for you
    to modify your description at the top of the pull request thread; it will be
    used again as the cover letter. You should use this space to describe what
    has changed since your previous version, so that your reviewers have some idea
    of what they're looking at. When the CI is done running, you can comment once
    more with `/submit` - GitGitGadget will automatically add a v2 mark to your

before it talks about doing the "/submit" again.  Expanding the
above into a bulletted list form like you did might make it easier
to follow through, perhaps?  I dunno.

  reply	other threads:[~2023-01-25 22:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  8:17 [PATCH] ssh signing: better error message when key not in agent Adam Szkoda via GitGitGadget
2023-01-18 11:10 ` Phillip Wood
2023-01-18 14:34   ` Phillip Wood
2023-01-18 15:28     ` Adam Szkoda
2023-01-18 16:29       ` Phillip Wood
2023-01-20  9:03         ` Fabian Stelzer
2023-01-23  9:33           ` Phillip Wood
2023-01-23 10:02             ` Fabian Stelzer
2023-01-23 16:17               ` Adam Szkoda
2023-01-24 15:26 ` [PATCH v2] " Adam Szkoda via GitGitGadget
2023-01-24 17:52   ` Junio C Hamano
2023-01-25 12:46     ` Adam Szkoda
2023-01-25 17:04       ` Junio C Hamano
2023-01-25 17:17       ` Junio C Hamano
2023-01-25 21:42       ` Eric Sunshine
2023-01-25 22:22         ` Junio C Hamano [this message]
2023-02-15  1:22           ` Eric Sunshine
2023-01-25 12:40   ` [PATCH v3] " Adam Szkoda via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedridzjw.fsf@gitster.g \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).