From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Thomas Rast <trast@inf.ethz.ch>,
Thomas Rast <trast@student.ethz.ch>,
git@vger.kernel.org, Michal Privoznik <mprivozn@redhat.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] perf: compare diff algorithms
Date: Wed, 07 Mar 2012 10:19:31 -0800 [thread overview]
Message-ID: <7vzkbsmfyk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <201203071903.02373.jnareb@gmail.com> (Jakub Narebski's message of "Wed, 7 Mar 2012 19:03:01 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> Beside extracting logic that sets GITPERLLIB into separate file like
> in Junio proposal?
That was not even a proposal. The part that deals with valgrind is
blatantly wrong (it shouldn't create symlinks in that code, it only
should figure out where things should be).
> You can always assume that it is fixed relative
> to perl/Git.pm, and use __DIR__ or $FindBin to make "use lib", e.g.
>
> use FindBin;
> use lib "$FindBin::Bin/../../perl";
Use of FindBin to find the location of the script is OK, but does
using "../../perl" really work?
We have this
GITPERLLIB="$GIT_BUILD_DIR"/perl/blib/lib:"$GIT_BUILD_DIR"/perl/blib/arch/auto/Git
to look for two places in test-lib.sh
next prev parent reply other threads:[~2012-03-07 18:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 10:59 [PATCH] config: Introduce --patience config variable Michal Privoznik
2012-03-06 11:49 ` Jeff King
2012-03-06 13:01 ` Thomas Rast
2012-03-06 13:15 ` [PATCH 1/2] perf: compare diff algorithms Thomas Rast
2012-03-06 13:15 ` [PATCH 2/2] Document the --histogram diff option Thomas Rast
2012-03-06 19:57 ` Junio C Hamano
2012-03-06 20:42 ` Thomas Rast
2012-03-06 19:52 ` [PATCH 1/2] perf: compare diff algorithms Junio C Hamano
2012-03-06 21:00 ` Thomas Rast
2012-03-06 21:18 ` Junio C Hamano
2012-03-06 21:41 ` Jakub Narebski
2012-03-07 12:44 ` Thomas Rast
2012-03-07 17:45 ` Junio C Hamano
2012-03-07 18:03 ` Jakub Narebski
2012-03-07 18:19 ` Junio C Hamano [this message]
2012-03-10 7:13 ` René Scharfe
2012-03-06 13:30 ` [PATCH] config: Introduce --patience config variable Jeff King
2012-03-06 13:32 ` Michal Privoznik
2012-03-06 13:38 ` Matthieu Moy
2012-03-06 14:09 ` Jeff King
2012-03-07 2:57 ` Junio C Hamano
2012-03-07 11:47 ` Jeff King
2012-03-07 17:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzkbsmfyk.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=mprivozn@redhat.com \
--cc=peff@peff.net \
--cc=trast@inf.ethz.ch \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).