git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Thomas Rast <trast@student.ethz.ch>, <git@vger.kernel.org>,
	Michal Privoznik <mprivozn@redhat.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] perf: compare diff algorithms
Date: Tue, 06 Mar 2012 13:18:58 -0800	[thread overview]
Message-ID: <7vr4x5qvgd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87y5rdzbpb.fsf@thomas.inf.ethz.ch> (Thomas Rast's message of "Tue, 6 Mar 2012 22:00:48 +0100")

Thomas Rast <trast@inf.ethz.ch> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>>
>> I am getting this (probably unrelated to this patch), by the way:
>>
>> $ make perf
>> make -C t/perf/ all
>> make[1]: Entering directory `/srv/project/git/git.git/t/perf'
>> rm -rf test-results
>> ./run
>> ...
>> perf 4 - grep --cached, expensive regex: 1 2 3 ok
>> # passed all 4 test(s)
>> 1..4
>> Can't locate Git.pm in @INC (@INC contains: /etc/perl ...) at ./aggregate.perl line 5.
>> BEGIN failed--compilation aborted at ./aggregate.perl line 5.
>
> It would seem that you are not installing Git.pm as part of your normal
> installation?

I actually am installing it in a quite vanilla way.

I think our installation procedure places Git.pm in git specific
perl library path where a simple invocation of "perl" that is
git-unaware will not look into, and we make sure that our scripts
still find the matching version of Git.pm by having "use lib" at the
beginning that points at the right directory.

But of course, this from a command line would not work:

	$ perl -MGit

I do not expect it to, and for the ease of testing new versions, I
prefer it not to work.

In any case, you should be able to do anything under t/ _before_
installing, so relying on having Git.pm in normal @INC is a double
no-no.

  reply	other threads:[~2012-03-06 21:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 10:59 [PATCH] config: Introduce --patience config variable Michal Privoznik
2012-03-06 11:49 ` Jeff King
2012-03-06 13:01   ` Thomas Rast
2012-03-06 13:15     ` [PATCH 1/2] perf: compare diff algorithms Thomas Rast
2012-03-06 13:15       ` [PATCH 2/2] Document the --histogram diff option Thomas Rast
2012-03-06 19:57         ` Junio C Hamano
2012-03-06 20:42           ` Thomas Rast
2012-03-06 19:52       ` [PATCH 1/2] perf: compare diff algorithms Junio C Hamano
2012-03-06 21:00         ` Thomas Rast
2012-03-06 21:18           ` Junio C Hamano [this message]
2012-03-06 21:41             ` Jakub Narebski
2012-03-07 12:44               ` Thomas Rast
2012-03-07 17:45                 ` Junio C Hamano
2012-03-07 18:03                 ` Jakub Narebski
2012-03-07 18:19                   ` Junio C Hamano
2012-03-10  7:13       ` René Scharfe
2012-03-06 13:30     ` [PATCH] config: Introduce --patience config variable Jeff King
2012-03-06 13:32     ` Michal Privoznik
2012-03-06 13:38       ` Matthieu Moy
2012-03-06 14:09         ` Jeff King
2012-03-07  2:57   ` Junio C Hamano
2012-03-07 11:47     ` Jeff King
2012-03-07 17:24       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4x5qvgd.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mprivozn@redhat.com \
    --cc=peff@peff.net \
    --cc=trast@inf.ethz.ch \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).